From owner-dev-commits-src-all@freebsd.org Sat May 8 05:22:26 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 65AA16291C2; Sat, 8 May 2021 05:22:26 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FcbKt27y6z4WPr; Sat, 8 May 2021 05:22:26 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from [192.168.0.12] (unknown [181.51.107.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: pfg) by smtp.freebsd.org (Postfix) with ESMTPSA id C990FD424; Sat, 8 May 2021 05:22:25 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Subject: Re: git: 5a4333a5378f - main - This takes Warners suggested approach to making it so that platforms that for whatever reason cannot include the RATELIMIT option can still work with rack. It adds two dummy functions that rack will call and find out that the highest hw supported b/w is 0 (which kinda makes sense and rack is already prepared to handle). To: Randall Stewart Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" References: <202105072134.147LYjPn018824@gitrepo.freebsd.org> From: Pedro Giffuni Organization: FreeBSD Message-ID: <4b297976-4b06-33a8-b390-18c01561b463@FreeBSD.org> Date: Sat, 8 May 2021 00:22:24 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 May 2021 05:22:26 -0000 On 07/05/2021 16:37, Jessica Clarke wrote: > On 7 May 2021, at 22:34, Randall Stewart wrote: >> The branch main has been updated by rrs: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=5a4333a5378f7afe4f8cab293a987865ae0c32c4 >> >> commit 5a4333a5378f7afe4f8cab293a987865ae0c32c4 >> Author: Randall Stewart >> AuthorDate: 2021-05-07 21:32:32 +0000 >> Commit: Randall Stewart >> CommitDate: 2021-05-07 21:32:32 +0000 >> >> This takes Warners suggested approach to making it so that >> platforms that for whatever reason cannot include the RATELIMIT option >> can still work with rack. It adds two dummy functions that rack will >> call and find out that the highest hw supported b/w is 0 (which >> kinda makes sense and rack is already prepared to handle). > Hi Randall, > Could you please start writing a proper separate subject line for your git > commits? This is not best practice, and many tools behave poorly in the > presence of one big paragraph at the start rather than a separate subject line, > including the email hook here. See [1] for FreeBSD’s own guide on the matter. > > Jess > > [1] https://docs.freebsd.org/en/articles/committers-guide/#commit-log-message > +1 even in git this breaks the shortlog in ugly ways.