Date: Thu, 8 Jan 2004 13:38:53 -0600 (CST) From: Mark Linimon <linimon@lonesome.com> To: FreeBSD-gnats-submit@FreeBSD.org Cc: dan@langille.org Subject: ports/61090: [patch] change characterization of ports that require source to build from BROKEN to IGNORE Message-ID: <200401081938.i08JcrhF073776@lonesome.lonesome.com> Resent-Message-ID: <200401081940.i08JeGBH072564@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 61090
>Category: ports
>Synopsis: [patch] change characterization of ports that require source to build from BROKEN to IGNORE
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Thu Jan 08 11:40:16 PST 2004
>Closed-Date:
>Last-Modified:
>Originator: Mark Linimon
>Release: FreeBSD 4.9-PRERELEASE i386
>Organization:
Lonesome Dove Computing Services
>Environment:
System: FreeBSD lonesome.lonesome.com 4.9-PRERELEASE FreeBSD 4.9-PRERELEASE #0: Fri Sep 5 01:19:33 CDT 2003 linimon@lonesome.lonesome.com:/usr/src/sys/compile/MULTIMEDIA_DEBUG i386
>Description:
A common usage among ports that require a kernel source tree
to compile correctly is to conditionally set BROKEN if the
required file(s) are not found. If I understand the intent
of the code in bsd.port.mk correctly, this would probably
better be styled as IGNORE and not BROKEN. As I understand
it, BROKEN is to indicate ports that are thought to be
temporarily unbuildable, and IGNORE is to indicate ports
that are permanently unbuildable in a given configuration.
For most end-users, the change will be academic. The bento
build cluster will not be affected, because it seems to have
source installed. The main difference will be to my own
ports monitoring code (which makes a clear distinction
between the two) and possibly FreshPorts (I'm not sure;
I have Cc:ed Dan just in case).
I have also Cc:ed maintainers of the affected ports
as a heads-up. I'm going to assign this to portmgr@
because I think it deserves discussion before any
commit hits the repository.
>How-To-Repeat:
(on a non-sourceful system) cd <portname>;make -V BROKEN
>Fix:
Index: audio/aureal-kmod/Makefile
===================================================================
RCS file: /home/pcvs/ports/audio/aureal-kmod/Makefile,v
retrieving revision 1.19
diff -r1.19 Makefile
42c42
< BROKEN= "FreeBSD 3.*, 4.0 are not supported"
---
> IGNORE= "FreeBSD 3.*, 4.0 are not supported"
72c72
< BROKEN= "Base system is outdated. This port needs -STABLE after 2002-04-22."
---
> IGNORE= "Base system is outdated. This port needs -STABLE after 2002-04-22."
82c82
< BROKEN= "Base system is outdated. This port needs -CURRENT after 2002-04-04."
---
> IGNORE= "Base system is outdated. This port needs -CURRENT after 2002-04-04."
88c88
< BROKEN= "You need to extract kernel source tree before building this package"
---
> IGNORE= "You need to extract kernel source tree before building this package"
Index: devel/linux_kdump/Makefile
===================================================================
RCS file: /home/pcvs/ports/devel/linux_kdump/Makefile,v
retrieving revision 1.19
diff -r1.19 Makefile
25c25
< BROKEN= "requires kernel source present in /sys"
---
> IGNORE= "requires kernel source present in /sys"
28c28
< BROKEN= "requires ktrace source present in /usr/src/usr.bin/ktrace"
---
> IGNORE= "requires ktrace source present in /usr/src/usr.bin/ktrace"
Index: emulators/rtc/Makefile
===================================================================
RCS file: /home/pcvs/ports/emulators/rtc/Makefile,v
retrieving revision 1.16
diff -r1.16 Makefile
36c36
< BROKEN= "Systems prior to 400013 are out of support"
---
> IGNORE= "Systems prior to 400013 are out of support"
40c40
< BROKEN= "Kernel source files required"
---
> IGNORE= "Kernel source files required"
Index: emulators/vmware2/Makefile
===================================================================
RCS file: /home/pcvs/ports/emulators/vmware2/Makefile,v
retrieving revision 1.59
diff -r1.59 Makefile
57c57
< BROKEN= "Systems prior to 400013 is out of support"
---
> IGNORE= "Systems prior to 400013 is out of support"
61c61
< BROKEN= "This software absolutely requires Linux procfs support"
---
> IGNORE= "This software absolutely requires Linux procfs support"
65c65
< BROKEN= "Kernel source files required"
---
> IGNORE= "Kernel source files required"
Index: emulators/vmware3/Makefile
===================================================================
RCS file: /home/pcvs/ports/emulators/vmware3/Makefile,v
retrieving revision 1.69
diff -r1.69 Makefile
54c54
< BROKEN= "Systems prior to FreeBSD 480102 currently out of support"
---
> IGNORE= "Systems prior to FreeBSD 480102 are not supported."
58c58
< BROKEN= "This software absolutely requires Linux procfs support"
---
> IGNORE= "You must install Linux procfs support to run this software"
61,63c61,63
< .if !exists(${SRC_BASE}/Makefile)
< BROKEN= "Kernel source files required"
< .endif
---
> #.if !exists(${SRC_BASE}/Makefile)
> IGNORE= "You must install the kernel source files to run this software"
> #.endif
Index: graphics/kix-kmod/Makefile
===================================================================
RCS file: /home/pcvs/ports/graphics/kix-kmod/Makefile,v
retrieving revision 1.3
diff -r1.3 Makefile
18c18
< BROKEN= "Requires kernel source (/usr/src/sys) to build"
---
> IGNORE= "Requires kernel source (/usr/src/sys) to build"
Index: graphics/plasma-kmod/Makefile
===================================================================
RCS file: /home/pcvs/ports/graphics/plasma-kmod/Makefile,v
retrieving revision 1.4
diff -r1.4 Makefile
18c18
< BROKEN= "Requires kernel source (/usr/src/sys) to build"
---
> IGNORE= "Requires kernel source (/usr/src/sys) to build"
Index: net/arla/Makefile
===================================================================
RCS file: /home/pcvs/ports/net/arla/Makefile,v
retrieving revision 1.25
diff -r1.25 Makefile
21c21
< BROKEN= requires kerberos
---
> IGNORE= requires kerberos
25c25
< BROKEN= requires kernel source
---
> IGNORE= requires kernel source
Index: net/ncplib/Makefile
===================================================================
RCS file: /home/pcvs/ports/net/ncplib/Makefile,v
retrieving revision 1.8
diff -r1.8 Makefile
17c17
< BROKEN= requires kernel source
---
> IGNORE= requires kernel source
Index: palm/uppc-kmod/Makefile
===================================================================
RCS file: /home/pcvs/ports/palm/uppc-kmod/Makefile,v
retrieving revision 1.1
diff -r1.1 Makefile
22c22
< BROKEN= "Requires kernel source (/usr/src/sys) to build"
---
> IGNORE= "Requires kernel source (/usr/src/sys) to build"
Index: security/libparanoia/Makefile
===================================================================
RCS file: /home/pcvs/ports/security/libparanoia/Makefile,v
retrieving revision 1.13
diff -r1.13 Makefile
25c25
< BROKEN= You need to have libc sources installed in /usr/src/lib/libc \
---
> IGNORE= You need to have libc sources installed in /usr/src/lib/libc \
Index: sysutils/cd9660_unicode/Makefile
===================================================================
RCS file: /home/pcvs/ports/sysutils/cd9660_unicode/Makefile,v
retrieving revision 1.8
diff -r1.8 Makefile
29c29
< BROKEN= "your FreeBSD version is not supported. Please update to the latest version and try again"
---
> IGNORE= "your FreeBSD version is not supported. Please update to the latest version and try again"
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200401081938.i08JcrhF073776>