From nobody Sun May 3 19:31:50 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g7vzm2vp4z6bx9Q for ; Sun, 03 May 2026 19:32:04 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g7vzl43YBz3tpQ for ; Sun, 03 May 2026 19:32:03 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-8acae26e564so40915796d6.2 for ; Sun, 03 May 2026 12:32:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1777836722; cv=none; d=google.com; s=arc-20240605; b=knfnz3u0jDvURAdC38Loly6oTLquw4roA10vvhMhd8HJX1UoWNC7AEGc23H2RX/8Kx kQkwEGc5qOkqtAuRVxWSomNqsGJ8+nN1VYcYL0p23+zlhAgp/pv+I01xoHSaQ+5L/J44 7HIdYny7LGct8Mi1NpDgQnLeHtdXOvxTFzpe98D/lz22cSzTHCZgV19OpEK4V1L54aKJ l+DZBsTtpR1D6etq/pMqJxMfUoud9vJtrVRcR2t1soNVrpkXreyV589oLoSCKX2Y3IsW CYonpCXr+0Pgc1i+9b14Yo1V63rlpIL5rjajTsO7Ijt3ZFC6BVXW7H+dGKAmApchKjeQ XNPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=KEM6l1hcVDQVqX+aukKW64DKb2oprVq/tvvIlVvRiX8=; fh=vxQmwe3je1yZFWYQ4Z5qDCuA2HfSk1XjoYC5DKpE1x0=; b=ijMShiuNWW5IQWY5wsyTZHUezxYGlPx5woeF72kQu4tR+6GmcRGzBHXSbYHtvsngbo Lq0wzFhxxOpGc7sOp8ibNr1jIxMiMfpPWrQ/r3b+3izqDfBNsX9DBwIyXeVdFenNeBug 6AId8GcT4Fz87HoprY1tP13HUttyPR3C42ajft6y4zQYPFMNzgXMpHHLE1ifQDoMGHZs HFzV4y30cgpOXMXnbcpn7am3ZgG+3Y1K8VFUgiM4k8EaD7Im0SizJAcdgpKXXn497K6J 4UIZde8RyCLeh/b8s7qmvQVgKmuQo2tpsbYBL+MqnsjFWCwbwu2g3QJBpyT/1PNLgwpa rBsg==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777836722; x=1778441522; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KEM6l1hcVDQVqX+aukKW64DKb2oprVq/tvvIlVvRiX8=; b=e4SVAd0EzP/In2eCwo5QF6nXgxkilnLLYwnN2QeNNNByXN6DCfV6fRbWHeplEq5O1n tw13/wmTZoCgdY7DI9rWK7zghCShaty4mRDHPSKbLooY3a9kYAiD3fWR4qQRmFsAgC3a cTbxTcFZtqAXp4iAaSBB5njYqXxBZmDZZJfVk7cNh3g1ZzSLvijE0Mo+L7w8j3TVn/CO gWirxqQM5plcj8ovF1IqPy8egP/tN6ddbpRxo57emP1o3cMT7GVBKGVoGALEaDWw30ip AHGIMEW7EHhPnsZB3zkbYcb5wSDSkidHbTvrgkLNdrvzGackjowK0MDRDCg7Zv33fNxX i2/A== X-Forwarded-Encrypted: i=1; AFNElJ/B88LHl4y5ltWdRlbNYJXh8+9JmO3x3gZEGEa0qj0PLdtqI9a2ODeL6jqJqV41Hb2Ncj+ySX/9VzU7GAFR85SHdIgrIA==@freebsd.org X-Gm-Message-State: AOJu0Yw+XB/Xf/gSAj7iy4xCuuB6D8lAaZ5FppMWnj6U12o/aq0HgA4q RHAfRcHRjMtgQBDqEPRi6Kq9vBm9qMMmSgnFERBGTtFSF3C7XnxHyUV7lIIxtzO1m5oLLh1MU5w zSMw0OcXraonyp7XUiJXaGClBM+T1LHvWDg== X-Gm-Gg: AeBDiesZRHf0E2pUknVMTdLdk9MgUhBt64Sxbi0JLhBePBcg8/KXO96Zgp6MmIXbyAG u9Gow/yZKovcfulqVBO9+ei1U1DoxDXLHAGATqmIUOOieiXB6gHNQS9Iqujruc3kb2m2sPVDmgg 8qGd9GiD3E5xTzVbTaX2PXQQJDqs5mBARLJ5ho4jlGsZZ4joPfJVWshyj+KGicwppnCaqaZsL3j jxwLD932ee8UFWAvcDpBHybizgcOVZHyfmEpH+oG4okp+RFLE5JtOTOcmxNV2Ck874hUlOa8cM7 WAOp3q0AV9T9etnk2T2TgVLhp3XCq6+5dtM7HTuZiZi3lrSlYs00VpZqTm/oHIdfq3r8OKsYWde Azklia+DXJXq5cJEXWffWe9Cb5BTew7YjU8mYK6lwayKEG/g1+itV4TUnDjQTnE9vQzKj X-Received: by 2002:ad4:5ce4:0:b0:8b3:fb6a:d35d with SMTP id 6a1803df08f44-8b6696db9b5mr137706956d6.47.1777836722101; Sun, 03 May 2026 12:32:02 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 References: <69f6b1ec.181e8.27d0b938@gitrepo.freebsd.org> <6C5FEC1A-D8E1-45B8-A80A-B32F81392058@freebsd.org> In-Reply-To: <6C5FEC1A-D8E1-45B8-A80A-B32F81392058@freebsd.org> From: Adrian Chadd Date: Sun, 3 May 2026 12:31:50 -0700 X-Gm-Features: AVHnY4L5lWsj72fWPxZd59ctEUa51Rs4cxCohA6FO3a1TC1luqDawdesJW4QnHY Message-ID: Subject: Re: git: 01674e15dedb - main - bsd.endian.mk: Optimize the handling of big/little endian determination. To: Jessica Clarke Cc: "Stephen J. Kiernan" , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4g7vzl43YBz3tpQ X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated I just hit this too. can we revert the diff for now until we figure out why it breaks ports building at least? -a On Sun, 3 May 2026 at 11:49, Jessica Clarke wrote: > > On 3 May 2026, at 03:24, Stephen J. Kiernan wrote: > > > > The branch main has been updated by stevek: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D01674e15dedb15f8ce498af0= 680c50bb075c5482 > > > > commit 01674e15dedb15f8ce498af0680c50bb075c5482 > > Author: Stephen J. Kiernan > > AuthorDate: 2024-04-03 23:25:19 +0000 > > Commit: Stephen J. Kiernan > > CommitDate: 2026-05-03 02:21:56 +0000 > > > > bsd.endian.mk: Optimize the handling of big/little endian determinat= ion. > > > > Add variables to contain lists of MACHINE_ARCH values to use > > to determine little or big endian. > > > > Only error out about not being able to determine endianess if > > TARGET_ENDIANNESS is empty and not cross-compiling. > > > > Reviewed by: sjg > > Obtained from: Hewlett Packard Enterprise Development LP > > Differential Revision: https://reviews.freebsd.org/D44629 > > --- > > share/mk/bsd.endian.mk | 39 +++++++++++++++++++++++++++++---------- > > 1 file changed, 29 insertions(+), 10 deletions(-) > > > > diff --git a/share/mk/bsd.endian.mk b/share/mk/bsd.endian.mk > > index 0c5ebb7aeba2..2a617a1d2794 100644 > > --- a/share/mk/bsd.endian.mk > > +++ b/share/mk/bsd.endian.mk > > @@ -1,20 +1,35 @@ > > > > -.if ${MACHINE_CPUARCH} =3D=3D "aarch64" || \ > > - ${MACHINE_CPUARCH} =3D=3D "arm" || \ > > - ${MACHINE_ARCH} =3D=3D "amd64" || \ > > - ${MACHINE_ARCH} =3D=3D "i386" || \ > > - ${MACHINE_ARCH} =3D=3D "powerpc64le" || \ > > - ${MACHINE_CPUARCH} =3D=3D "riscv" > > Losing MACHINE_CPUARCH makes me sad as a downstream that adds new > MACHINE_ARCH for aarch64 and riscv. For riscv at least it=E2=80=99s now r= iscv* > which I guess is close enough, but for aarch64 it=E2=80=99s not wildcarde= d. > Similarly arm though I don=E2=80=99t care about that personally. > > > +MACHINE_ARCH_LIST.little =3D \ > > + aarch64 \ > > + amd64 \ > > + armv7 \ > > + i386 \ > > + powerpc64le \ > > + riscv* > > + > > +MACHINE_ARCH_LIST.big =3D \ > > + powerpc \ > > + powerpc64 > > + > > +.for e in big little > > +N_$e:=3D ${MACHINE_ARCH_LIST.$e:${M_ListToSkip}} > > Should we be worried about catching MACHINE(_ARCH) being empty? > > Jessica > > > +.endfor > > + > > +# For the host, we need to look at the host architecture > > +.if ${MACHINE:Nhost*} =3D=3D "" > > +_ENDIAN_ARCH=3D${_HOST_ARCH} > > +.else > > +_ENDIAN_ARCH=3D${MACHINE_ARCH} > > +.endif > > + > > +.if ${_ENDIAN_ARCH:${N_little}} =3D=3D "" > > TARGET_ENDIANNESS=3D 1234 > > CAP_MKDB_ENDIAN=3D -l > > LOCALEDEF_ENDIAN=3D -l > > -.elif ${MACHINE_ARCH} =3D=3D "powerpc" || \ > > - ${MACHINE_ARCH} =3D=3D "powerpc64" > > +.elif ${_ENDIAN_ARCH:${N_big}} =3D=3D "" > > TARGET_ENDIANNESS=3D 4321 > > CAP_MKDB_ENDIAN=3D -b > > LOCALEDEF_ENDIAN=3D -b > > -.elif ${.MAKE.OS} =3D=3D "FreeBSD" > > -.error Don't know the endian of this architecture > > .else > > # > > # During bootstrapping on !FreeBSD OSes, we need to define some value. = Short of > > @@ -33,3 +48,7 @@ TARGET_ENDIANNESS=3D 1234 > > CAP_MKDB_ENDIAN=3D -B # Poisoned value, invalid flags for both cap_mkdb > > LOCALEDEF_ENDIAN=3D -B # and localedef. > > .endif > > + > > +.if empty(TARGET_ENDIANNESS) && ${.MAKE.OS} =3D=3D "FreeBSD" > > +.error Don't know the endianness of this architecture > > +.endif > > > >