Date: Sat, 3 Mar 2012 13:30:21 GMT
From: Matthew Seaman <m.seaman@infracaninophile.co.uk>
To: freebsd-ports-bugs@FreeBSD.org
Subject: Re: ports/165623: Mk/bsd.comands.mk et al -- conflicting uses of ${FILE}
Message-ID: <201203031330.q23DULGH010669@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/165623; it has been noted by GNATS.
From: Matthew Seaman <m.seaman@infracaninophile.co.uk>
To: Chris Rees <utisoft@gmail.com>
Cc: "bug-followup@freebsd.org" <bug-followup@freebsd.org>
Subject: Re: ports/165623: Mk/bsd.comands.mk et al -- conflicting uses of
${FILE}
Date: Sat, 03 Mar 2012 13:29:41 +0000
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig9B12DC8099B48675AC670E9F
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
On 03/03/2012 12:56, Chris Rees wrote:
> Or we could put the portlint check in, and people who don't want to see=
it
> complain could use lowers for loop vars.
>=20
> Sorry to go on about this, but it's very important to differentiate,
> considering that their behaviour is very different from regular variabl=
es.
>=20
> Note that I withdraw my objection to FILE_CMD as per pointers from othe=
rs :)
So make it a matter of style that loop iterators should be lower case?
That is an idea I can agree with. Not being too prescriptive about it,
and allowing people to make that modification organically -- when they
have to update a port for another reason, etc. is also something I can
agree with.
Although it turns out there's fewer instances of using uppercase
iterators than I at first thought:
lucid-nonsense:/usr/ports:% grep -rlE '^\. *for +[A-Z]+' * | wc -l
341
Cheers,
Matthew
--=20
Dr Matthew J Seaman MA, D.Phil. 7 Priory Courtyard
Flat 3
PGP: http://www.infracaninophile.co.uk/pgpkey Ramsgate
JID: matthew@infracaninophile.co.uk Kent, CT11 9PW
--------------enig9B12DC8099B48675AC670E9F
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.16 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk9SHM4ACgkQ8Mjk52CukIw6TgCeNt7kOXFk4lPcu9awbudXqTcR
FGsAnigueP1WudsCwjR9NJ+9I7jJg+wX
=vO2U
-----END PGP SIGNATURE-----
--------------enig9B12DC8099B48675AC670E9F--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201203031330.q23DULGH010669>