From owner-cvs-all@FreeBSD.ORG Sat Oct 29 04:03:32 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6387216A41F; Sat, 29 Oct 2005 04:03:32 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from speedfactory.net (mail5.speedfactory.net [66.23.216.218]) by mx1.FreeBSD.org (Postfix) with ESMTP id AD2A843D45; Sat, 29 Oct 2005 04:03:31 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.5b3) with ESMTP id 986705 for multiple; Sat, 29 Oct 2005 00:01:28 -0400 Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) (authenticated bits=0) by server.baldwin.cx (8.13.1/8.13.1) with ESMTP id j9T43RtT012674; Sat, 29 Oct 2005 00:03:27 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Bill Paul Date: Sat, 29 Oct 2005 00:03:24 -0400 User-Agent: KMail/1.8 References: <200510290301.j9T31H3P083494@repoman.freebsd.org> In-Reply-To: <200510290301.j9T31H3P083494@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200510290003.25709.jhb@FreeBSD.org> X-Spam-Status: No, score=-2.8 required=4.2 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on server.baldwin.cx X-Server: High Performance Mail Server - http://surgemail.com r=100 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/txp if_txp.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Oct 2005 04:03:32 -0000 On Friday 28 October 2005 11:01 pm, Bill Paul wrote: > wpaul 2005-10-29 03:01:17 UTC > > FreeBSD src repository > > Modified files: > sys/dev/txp if_txp.c > Log: > Remove call to txp_set_filter() from txp_attach(). txp_set_filter() nee= ds > the ifp, so you can't call it before doing if_alloc(). Also, there's > really no need to call it here anyway: the code I originally ported from > OpenBSD incorrectly set the station address only once at device attach > time, instead of setting in txp_init(). This meant you couldn't change > the address with ifconfig txp0 ether xx:xx:xx:xx:xx:xx. I added the > call to txp_set_filter() in txp_init() to correct this, but forgot to > remove the call from txp_attach(). Until now, it never mattered. > > With this fix, the txp driver tests good: > > txp0: <3Com 3cR990-TX-97 Etherlink with 3XP Processor> port 0xb800-0xb8= 7f > mem 0xe6800000-0xe683ffff irq 12 at device 10.0 on pci0 txp0: Ethernet > address: 00:01:03:d4:91:4f Thanks again for testing and fixing the bogons. =2D-=20 John Baldwin =A0<>< =A0http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" =A0=3D =A0http://www.FreeBSD.org