From owner-svn-src-all@freebsd.org Sat Nov 5 14:30:12 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 00BD5C3190A; Sat, 5 Nov 2016 14:30:12 +0000 (UTC) (envelope-from alfred@freebsd.org) Received: from elvis.mu.org (elvis.mu.org [IPv6:2001:470:1f05:b76::196]) by mx1.freebsd.org (Postfix) with ESMTP id E6B317F7; Sat, 5 Nov 2016 14:30:11 +0000 (UTC) (envelope-from alfred@freebsd.org) Received: from Alfreds-MacBook-Pro-2.local (unknown [IPv6:2601:645:8003:a4d6:8de:34f5:a947:3165]) by elvis.mu.org (Postfix) with ESMTPSA id 9564A346DE6A; Sat, 5 Nov 2016 07:30:11 -0700 (PDT) Subject: Re: svn commit: r308314 - head/usr.bin/sed To: Konstantin Belousov , "Pedro F. Giffuni" References: <201611042049.uA4Knxcx019490@repo.freebsd.org> <20161105090733.GT54029@kib.kiev.ua> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Alfred Perlstein Organization: FreeBSD Message-ID: <6d9123fb-2b0a-c4a4-c584-d71874074d47@freebsd.org> Date: Sat, 5 Nov 2016 07:30:10 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161105090733.GT54029@kib.kiev.ua> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Nov 2016 14:30:12 -0000 On 11/5/16 2:07 AM, Konstantin Belousov wrote: > On Fri, Nov 04, 2016 at 08:49:59PM +0000, Pedro F. Giffuni wrote: >> Author: pfg >> Date: Fri Nov 4 20:49:59 2016 >> New Revision: 308314 >> URL: https://svnweb.freebsd.org/changeset/base/308314 >> >> Log: >> sed(1): add LEGACY_BSDSED_COMPAT compile-time flag. >> >> In r297602, which included a __FreeBSD_version bump to 1100105, we changed >> sed 'i' and 'a' from discarding whitespaces to conform with what GNU and >> sysvish sed do. >> >> There are arguments in favor of keeping the old behavior but the new >> behavior is also useful for migration purposes. It seems important to at >> least consider the case of developers depending on the previous behavior, >> so add a CFLAG to enable the old behaviour. > If such legacy behavior appears to be useful or even important for > real-world scenarios, I think that an environment variable controlling > it is more practical and traditional than the recompilation. > +1