From owner-svn-src-all@freebsd.org Sat Feb 10 17:42:11 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C64B6F0E7B7; Sat, 10 Feb 2018 17:42:11 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-lf0-x233.google.com (mail-lf0-x233.google.com [IPv6:2a00:1450:4010:c07::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0E55D692CA; Sat, 10 Feb 2018 17:42:11 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by mail-lf0-x233.google.com with SMTP id a204so15349049lfa.2; Sat, 10 Feb 2018 09:42:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=O96WKeAmPvWkZgiUHMqiPP5VfcGo75PPpCLpP7INs/w=; b=AgPRnLSVyYN2bgW+IDT/mfUjDBE00eK8+XX8oFDuUNpSAZpDi1lcEOWgdScedr9Q51 3RjtfHaDpsMDRZxAIyZghlRyUPX7wkJt0bEry0bNlRCxm3ZleEMvqcTgJ7E72lVZKWyn qHmQnHLXkuKliIG/RVA4xFoNbvpJpxOLLHF1yHrJMT6dptnYNysx3bMCb6+YBJspwIhp KwDfV1gWqdm6MzujdJD6VeTOt5692sqeV6AMyfinuV6ZahTMnf0JYgf89eUbSkWreifv q7pI9mp24vSdGjL9I2IdFDiVRmKLKQEPkqRbOovgqCk0ppsOMdUrRJ7fiB+FPZ2eN+ep 8QbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=O96WKeAmPvWkZgiUHMqiPP5VfcGo75PPpCLpP7INs/w=; b=tjVIctAnDefoO2LGO3Ps9M9s4hVLP+xNYcL3m3rlJW56225xojhtGNzFYh2rVeZ0Rv UAZZuETbvzndOyeVK4eYk2yh7eK9NGkwVQXAecz56a/h2uTJWJyFsUAv8P+MTcQ3NqYU nRIpXtaYbCL6ZVEYOVYDtHclxEYZNvxym0Y9PR1V2OM5zugYS0v59DgpuOirxjXWj6KY yJXricZ6yoOaokU172SpDOiJ1J0dyWTyONErch0Z5JWUD5ML4cD9F/vqFJxMCkIbu6Vm LnfkrIeY6osB8cwof2oEgXlrvDCDMXC8TS1aUIRRH+sN0V8Lkp7W4HhbhN9/sMDAMi18 VVOQ== X-Gm-Message-State: APf1xPCjsZkXOlo1F6ujwrJhYwzBNvsPmH+f1QqmVM3Jkn2TCDRclhOr 89PxIlFEO0ttbC3yNCB9QYIOkVWDZrn9mL1SN0I= X-Google-Smtp-Source: AH8x224MEUIUoxpWi0nJ4ZBTZcvKPRifrbJ5vEJ6uPCr9RNfmaz0BvbK0K+fdZxIs9X9vNEl0dEsUHfiGx9N+LBfEUY= X-Received: by 10.25.56.86 with SMTP id d22mr4565870lfj.46.1518284529283; Sat, 10 Feb 2018 09:42:09 -0800 (PST) MIME-Version: 1.0 Sender: chmeeedalf@gmail.com Received: by 10.46.75.1 with HTTP; Sat, 10 Feb 2018 09:42:08 -0800 (PST) In-Reply-To: References: <201802091946.w19Jkqb3038864@repo.freebsd.org> From: Justin Hibbits Date: Sat, 10 Feb 2018 11:42:08 -0600 X-Google-Sender-Auth: nF_3a87PGcSK3NicVobnK0G_nNA Message-ID: Subject: Re: svn commit: r329077 - head/usr.bin/tftp To: Pedro Giffuni Cc: Ed Maste , Conrad Meyer , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Feb 2018 17:42:12 -0000 On Sat, Feb 10, 2018 at 11:10 AM, Pedro Giffuni wrote: > > > On 02/10/18 11:13, Justin Hibbits wrote: >> >> On Fri, Feb 9, 2018 at 7:22 PM, Ed Maste wrote: >>> >>> On 9 February 2018 at 14:46, Conrad Meyer wrote: >>>> >>>> Author: cem >>>> Date: Fri Feb 9 19:46:51 2018 >>>> New Revision: 329077 >>>> URL: https://svnweb.freebsd.org/changeset/base/329077 >>>> >>>> Log: >>>> tftp(1): Fix libedit state corruption involving signals >>> >>> From https://ci.freebsd.org/job/FreeBSD-head-mips-build/391/console: >>> >>> 01:15:24 --- all_subdir_usr.bin/tftp --- >>> 01:15:24 --- main.o --- >>> 01:15:24 cc1: warnings being treated as errors >>> 01:15:24 /usr/src/usr.bin/tftp/main.c: In function 'main': >>> 01:15:24 /usr/src/usr.bin/tftp/main.c:182: warning: 'hist' may be used >>> uninitialized in this function >>> 01:15:24 /usr/src/usr.bin/tftp/main.c:181: warning: 'el' may be used >>> uninitialized in this function >>> >> After initializing these, I see the following interesting error: >> >> /home/chmeee/freebsd/head/usr.bin/tftp/main.c:181: warning: variable >> 'el' might be clobbered by 'longjmp' or 'vfork' >> /home/chmeee/freebsd/head/usr.bin/tftp/main.c:182: warning: variable >> 'hist' might be clobbered by 'longjmp' or 'vfork' >> >> This appears to be a known bug in gcc, at >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=24239 so I don't know >> what the best way to fix it is. > > > Independent of the compiler bug, it does seem like 'el' and 'hist' can be > used uninitialized for the non-interactive case. > > Untested, but perhaps an only-when-needed initialization like this may > workaround the compiler bug. > > Cheers, > > Pedro. Nope, I tried that as well, and hit the compiler bug. r329106 works around both. - Justin