From owner-freebsd-java@FreeBSD.ORG  Mon Aug 25 20:42:26 2003
Return-Path: <owner-freebsd-java@FreeBSD.ORG>
Delivered-To: freebsd-java@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 87B8516A4BF; Mon, 25 Aug 2003 20:42:26 -0700 (PDT)
Received: from mail.chesapeake.net (chesapeake.net [208.142.252.6])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 5AEC043FBF; Mon, 25 Aug 2003 20:42:25 -0700 (PDT)
	(envelope-from jroberson@chesapeake.net)
Received: from localhost (jroberson@localhost)
	by mail.chesapeake.net (8.11.6/8.11.6) with ESMTP id h7Q3fmv67730;
	Mon, 25 Aug 2003 23:41:49 -0400 (EDT)
	(envelope-from jroberson@chesapeake.net)
Date: Mon, 25 Aug 2003 23:41:48 -0400 (EDT)
From: Jeff Roberson <jroberson@chesapeake.net>
To: David Xu <davidxu@viatech.com.cn>
In-Reply-To: <3F49E267.3070302@viatech.com.cn>
Message-ID: <20030825234011.F12093-100000@mail.chesapeake.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: "deischen@freebsd.org" <deischen@freebsd.org>
cc: "threads@freebsd.org" <threads@freebsd.org>
cc: "freebsd-java@freebsd.org" <freebsd-java@freebsd.org>
Subject: Re: vmark hangs with libthr and libkse
X-BeenThere: freebsd-java@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting Java to FreeBSD <freebsd-java.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-java>,
	<mailto:freebsd-java-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-java>
List-Post: <mailto:freebsd-java@freebsd.org>
List-Help: <mailto:freebsd-java-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-java>,
	<mailto:freebsd-java-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Aug 2003 03:42:26 -0000

On Mon, 25 Aug 2003, David Xu wrote:

> Sheldon Hearn wrote:
>
> >On (2003/08/25 15:47), David Xu wrote:
> >
> >
> >
> >>>I heartily endorse your patch. :-)
> >>>
> >>>
> >>>
> >>Thanks, I am pleased to see libkse works. :-)
> >>However don't expect I will commit it,  kernel scheduler interface is a
> >>bit weird,  so
> >>I  won't try to add another weird code.
> >>
> >>
> >
> >Does Jeff know about your patch?  Perhaps he'd be willing to review and
> >commit, since he's the original author of SCHED_ULE.
> >
> >
> No,  I think he does not know the patch.
> Please don't commit it,  there is a performance problem, after each time
> a thread is exited,
> I must exit a kse and then let scheduler reinitialized it. In general, I
> needn't manage a struct kse,
> it should be a scheduler internal data.
>

Why do you need to do adjustrunqueue() in sched_prio?  I also don't
understand the case in sched_switchout().  Can you please explain that?

Other than that this patch seems fine.  KSE is technically missing the
proper sched api calls which is why ULE doesn't work with it.

Cheers,
Jeff