From nobody Mon Sep 22 08:38:17 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cVc2L23g3z68npw; Mon, 22 Sep 2025 08:38:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cVc2L1BvZz3sTB; Mon, 22 Sep 2025 08:38:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758530298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0Yq4+cKd0qnfLWMoMENv3DBZbAk/aquwnu3Hn1IWX6g=; b=rIRcwR3rsmStc4a5JPvK0EJ1ipvgYYR4ERcHxUakO8MTMWz5kaOrsHq/UI67FfWq2eH06t bAR8rDn/2JU8TdPeOjD+x5tFF0MXgoosWv/JudVBrxqCrP5RoCT4++DdZOKk5TgOT2TLav CPP/ovoyLx2AIsqWSIE0kngwRab/AR5tqu7TAuOL5nUzxMT3f9PjqJrWXWT9SiGXXpvo6y FCq1aQ+Fvidw1slt9AH34B0a6/toHgXDVluMrIS9GsHxgVKxL45srKwNmeFLYGFJa5XGai DHGOVW+FHZ3MuBzEHJGf8Y0ShZW5zneqZv8MFEyETdbEPTpX5reDvTx9FV0Iig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758530298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0Yq4+cKd0qnfLWMoMENv3DBZbAk/aquwnu3Hn1IWX6g=; b=kFhUKrrmw7jq4cEGTIQhmbCqeKoFgLUWpgVN24cAP5787EjqlgWOG7p6sXyXB7D5RTPguL pm08aVZt3gIuKNFDzFtkaj6vEpoe602/IL0Ex7IP4fInHiiyi50Sj9kQ3S85O8OZi0Iz8j yLG16bc55ha2BK6cLaHJ+0UweQJBJavSBkkWEY0mTEwKOc/1ROsPGsK2+9GCEpWT95YffO pe48lOvIRO5NgG7m8ClJgDdXdS8OK6tJf/OU+fJ3zaVxkWcGpXOCNc0tYIqWMeF7hVsn7l VPPokI9koxWP8pLlChwnhAM9J/5DOCI6YqzN69GNcMWJFL1Exf95VcQodZF1Ww== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758530298; a=rsa-sha256; cv=none; b=AkyM6wE3SjZt2PVN4F89IEHz204rI4rnxLnDwdctNh5HoXQadtyPj/zcdPmNVX688wRwM9 OGJUVlaagVOzJhTj0RxXTBUsuhhqzj38yjRe3NQku1XGrVeIlqwO4PQabL4UXhAtmiOzb2 C4saWx02PK1jyN4Wey71wqjuSl8cqmFO+b2v32lT0xTAJ/6Ott7xcMbUVIh2Bs/ZYM/mNJ voxfstS/Ywf7OU7J4ykRMr0DfUUFEzUkLpCtdey5bBZAhcxmpYQ/xSBm1IXblz2LDtWzpo 2meAzAz5R9V4fxBKsX9oB5JAXpsuLVIr/Wh/qYtg7tDvC32EhDmYnY3JBKZ17A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cVc2K6vMKzslr; Mon, 22 Sep 2025 08:38:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58M8cHSw006151; Mon, 22 Sep 2025 08:38:17 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58M8cH5S006148; Mon, 22 Sep 2025 08:38:17 GMT (envelope-from git) Date: Mon, 22 Sep 2025 08:38:17 GMT Message-Id: <202509220838.58M8cH5S006148@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Vladimir Kondratyev Subject: git: 1e74951b6cd8 - main - iichid(4): Do not add 2 leading "length" bytes to input report length List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: wulf X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1e74951b6cd8132ae417177336b7180e174a5e3f Auto-Submitted: auto-generated The branch main has been updated by wulf: URL: https://cgit.FreeBSD.org/src/commit/?id=1e74951b6cd8132ae417177336b7180e174a5e3f commit 1e74951b6cd8132ae417177336b7180e174a5e3f Author: Vladimir Kondratyev AuthorDate: 2025-09-22 08:37:20 +0000 Commit: Vladimir Kondratyev CommitDate: 2025-09-22 08:37:20 +0000 iichid(4): Do not add 2 leading "length" bytes to input report length MFC after: 1 week fixes: 36027361f9cf ("iichid: Stop using split I²C bus transactions") --- sys/dev/iicbus/iichid.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/sys/dev/iicbus/iichid.c b/sys/dev/iicbus/iichid.c index 6d95d6d2d4f8..5ca3f1b84e48 100644 --- a/sys/dev/iicbus/iichid.c +++ b/sys/dev/iicbus/iichid.c @@ -540,7 +540,7 @@ iichid_sampling_task(void *context, int pending) error = iichid_cmd_read(sc, sc->intr_buf, sc->intr_bufsize, &actual); if (error == 0) { if (actual > 0) { - sc->intr_handler(sc->intr_ctx, sc->intr_buf + 2, actual); + sc->intr_handler(sc->intr_ctx, sc->intr_buf + 2, actual - 2); sc->missing_samples = 0; if (sc->dup_size != actual || memcmp(sc->dup_buf, sc->intr_buf, actual) != 0) { @@ -607,7 +607,7 @@ iichid_intr(void *context) if (sc->power_on && sc->open) { if (actual != 0) sc->intr_handler(sc->intr_ctx, sc->intr_buf + 2, - actual); + actual - 2); else DPRINTF(sc, "no data received\n"); } @@ -822,7 +822,7 @@ iichid_intr_setup(device_t dev, device_t child __unused, hid_intr_t intr, * report in the descriptor, and add two for the length field. */ rdesc->rdsize = rdesc->rdsize == 0 ? - le16toh(sc->desc.wMaxInputLength) : rdesc->isize + 2; + le16toh(sc->desc.wMaxInputLength) - 2 : rdesc->isize; /* Write and get/set_report sizes are limited by I2C-HID protocol. */ rdesc->grsize = rdesc->srsize = IICHID_SIZE_MAX; rdesc->wrsize = IICHID_SIZE_MAX; @@ -832,7 +832,7 @@ iichid_intr_setup(device_t dev, device_t child __unused, hid_intr_t intr, sc->intr_handler = intr; sc->intr_ctx = context; - sc->intr_bufsize = rdesc->rdsize; + sc->intr_bufsize = rdesc->rdsize + 2; sc->intr_buf = realloc(sc->intr_buf, sc->intr_bufsize, M_DEVBUF, M_WAITOK | M_ZERO); #ifdef IICHID_SAMPLING @@ -1094,7 +1094,8 @@ iichid_probe(device_t dev) } if (le16toh(sc->desc.wHIDDescLength) != 30 || - le16toh(sc->desc.bcdVersion) != 0x100) { + le16toh(sc->desc.bcdVersion) != 0x100 || + le16toh(sc->desc.wMaxInputLength) < 2) { DPRINTF(sc, "HID descriptor is broken\n"); return (ENXIO); }