From owner-freebsd-current@FreeBSD.ORG  Wed Mar 29 00:06:23 2006
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B49CD16A400;
	Wed, 29 Mar 2006 00:06:23 +0000 (UTC)
	(envelope-from dillon@apollo.backplane.com)
Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5F44443D49;
	Wed, 29 Mar 2006 00:06:23 +0000 (GMT)
	(envelope-from dillon@apollo.backplane.com)
Received: from apollo.backplane.com (localhost [127.0.0.1])
	by apollo.backplane.com (8.13.4.20060308/8.13.4) with ESMTP id
	k2T06MoP038891; Tue, 28 Mar 2006 16:06:23 -0800 (PST)
Received: (from dillon@localhost)
	by apollo.backplane.com (8.13.4.20060308/8.13.4/Submit) id
	k2T066Cr038883; Tue, 28 Mar 2006 16:06:06 -0800 (PST)
Date: Tue, 28 Mar 2006 16:06:06 -0800 (PST)
From: Matthew Dillon <dillon@apollo.backplane.com>
Message-Id: <200603290006.k2T066Cr038883@apollo.backplane.com>
To: Adrian Steinmann <ast@marabu.ch>
References: <20060325180630.V31295@pano.marabu.ch>
	<44279BAC.4020904@micom.mng.net>
	<B7A23617-C836-46F1-BE61-E3435A3347B0@marabu.ch>
Cc: Ganbold <ganbold@micom.mng.net>, freebsd-current@freebsd.org,
	dougb@freebsd.org
Subject: Re: bin/94767: [patch] rcorder(8) dumps core when does not use a
	proper RCng script (dansguardian)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Mar 2006 00:06:23 -0000

    I commented out the free()'s in DragonFly.  The reason is that the
    free()s don't take into account the fact that there can be circular 
    dependancies on those structures.  If a circular dependancy occurs,
    you wind up with a use-after-free and then a double-free situation.

    Commenting out the free() was the easiest solution.

						-Matt