From nobody Sat Apr 5 01:36:19 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZTyjz397yz5sljP for ; Sat, 05 Apr 2025 01:36:23 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZTyjy5HXyz3vpj for ; Sat, 05 Apr 2025 01:36:22 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=hardenedbsd.org header.s=google header.b=ErGfbDrJ; dmarc=none; spf=pass (mx1.freebsd.org: domain of shawn.webb@hardenedbsd.org designates 2607:f8b0:4864:20::d30 as permitted sender) smtp.mailfrom=shawn.webb@hardenedbsd.org Received: by mail-io1-xd30.google.com with SMTP id ca18e2360f4ac-85db7a3da71so229248439f.1 for ; Fri, 04 Apr 2025 18:36:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; t=1743816981; x=1744421781; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oj6HMH2AlPud5UGxSiYK/eFAoYohvoTz1kWQKTey7pM=; b=ErGfbDrJ9UYUpgkr9JWffFljGGZEEtHaz9P6NuwhWNy618643nydJj0TRURUBiCuBW 3Z9tf4F1zZraDU2ViszcaCY9RQR5ptHgSeX2xvpBIB/kUw6td0QCgZ81X9h2VcdH7joG Soz5WO4D7ggqjEisNCXEcAQQL+Ig+Vaun5/kiaa2uc1iUAOFpkQrUFpnh+k2cKP4PZbt 1j34Ltt44v+Si7odlQ8k8/wL43dwN6CPP628Y+dWVUTp2bJCcTHO68Y0j/1uNTxPvUOK WMPzpV+Gb05TREC4YpW1VxVqHpFEKSQboPvPxS6qOB5y102QErN5stFBTPi2YqOkHj38 FKvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743816981; x=1744421781; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oj6HMH2AlPud5UGxSiYK/eFAoYohvoTz1kWQKTey7pM=; b=ZCPf3q8PVvmtenAMmPohSIaOrKIPKx7liSABfD4izJcTsXsj/E6l95clzMkN6EETvP w1ly9wArzPcPpm40drvUyDvsemODBbfDfM/42rlRTye3ufLddzLzQTY7k3XeLQ9PFeUA w1bWsVsIS/uWEC+aeuv1UixXSaWqzGSO0G5z8ZtY2hauEQG2sPUk9vpEEMF+ORdRpzuJ uY1Br9zrsRSk1odt98pTwTTy0maWfGRrRbbKl6cHvp8qydTWuuEXuphsfQM8FOk+jenb 3FrTKu684vJIbSZDyPw1Eoil643XYmx3MfGgl3uR+0CAaCAh51Ct+rWzV80r/LXSCTI1 YK4A== X-Gm-Message-State: AOJu0Yw1BMhd1ZaSRKVWbaOjI6KNptzX14SXdOlt5vIMr28FWU1d2DJt 7n4Xrf/3CPOH8W441PHZGDHXfjWlM8mAuzRhKHzi2s89iuYiLmzug92K8UM2symyYzVLWrXYIkU sV6E= X-Gm-Gg: ASbGncswKf1DgNc/RbRUD70KG3YW3kwB71UC0ZVNcOWGxfI81lr3BYZF6OhULh+OWj9 l5hFjysr763wMCfZxgA0tyk3O+TkVgCEMNwJ5NbHm4/szckWWIukV2pDZKr31U7bwwFutrbsEFh vXme6I8exRo8E0OXN6wSmtgPo9gFbIe+mqsL9PRvsEvF/J7Lzr2cwyAeN2O560JDRKoMKa1LVsK /9efYlsa1gdYnYaVtdWZsoLDwAyuE1a/XeWffg+JRJvz1kE8M6JbeUGyPkQSGR9XgqYxBhDnTyP Wdz+rF27kTEXUaHsch8V87GCnTs= X-Google-Smtp-Source: AGHT+IGODg8f441SLXTMXcCmY3RJgCecirv6X9Phji8hqlrHrZcW9lw0xn5CygO2gCjDVzO4PrIv4w== X-Received: by 2002:a05:6602:3a12:b0:85d:a211:9883 with SMTP id ca18e2360f4ac-8611c3bae5bmr481460239f.10.1743816981608; Fri, 04 Apr 2025 18:36:21 -0700 (PDT) Received: from mutt-hbsd ([2001:470:4001:1::95]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4f4b5c3041asm1092381173.6.2025.04.04.18.36.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Apr 2025 18:36:20 -0700 (PDT) Date: Sat, 5 Apr 2025 01:36:19 +0000 From: Shawn Webb To: Rick Macklem Cc: FreeBSD CURRENT Subject: Re: Heads Up: commit 2ec2ba7e232d just hit main Message-ID: X-Operating-System: FreeBSD mutt-hbsd 14.2-STABLE-HBSD FreeBSD 14.2-STABLE-HBSD HARDENEDBSD-14-STABLE amd64 X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <2rq3bpvhclcipvgg3mo4gml7ysuzbvt6rfnzkprceumzeaeh4b@casrpprm6mgt> List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5qny3xgl73u3aeli" Content-Disposition: inline In-Reply-To: X-Spamd-Result: default: False [-5.07 / 15.00]; SIGNED_PGP(-2.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.97)[-0.968]; MID_RHS_NOT_FQDN(0.50)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; R_DKIM_ALLOW(-0.20)[hardenedbsd.org:s=google]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_LAST(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[hardenedbsd.org:+]; ARC_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; DMARC_NA(0.00)[hardenedbsd.org]; FROM_HAS_DN(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; MISSING_XM_UA(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; TAGGED_RCPT(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::d30:from] X-Rspamd-Queue-Id: 4ZTyjy5HXyz3vpj X-Spamd-Bar: ----- --5qny3xgl73u3aeli Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: Heads Up: commit 2ec2ba7e232d just hit main MIME-Version: 1.0 On Sat, Apr 05, 2025 at 01:27:17AM +0000, Shawn Webb wrote: > On Sat, Apr 05, 2025 at 01:04:25AM +0000, Shawn Webb wrote: > > On Fri, Apr 04, 2025 at 05:40:21PM -0700, Rick Macklem wrote: > > > On Fri, Apr 4, 2025 at 10:50=E2=80=AFAM Shawn Webb wrote: > > > > > > > > On Thu, Apr 03, 2025 at 06:12:59PM -0700, Rick Macklem wrote: > > > > > On Thu, Apr 3, 2025 at 4:52=E2=80=AFPM Shawn Webb wrote: > > > > > > > > > > > > On Wed, Apr 02, 2025 at 01:51:26PM -0700, Rick Macklem wrote: > > > > > > > The commit 2ec2ba7e232d just hit main. I do not think it will > > > > > > > cause problems, but it is fairly large. > > > > > > > > > > > > > > Man page updates will be done as separate commits. > > > > > > > > > > > > > > Hopefully this will not cause grief, rick > > > > > > > > > > > > Hey Rick, > > > > > > > > > > > > The patch review test plan mentions a patch to ZFS itself to su= pport > > > > > > named attributes. Is that patch available somewhere? > > > > > The ZFS patch is currently in phabricator as D49654. > > > > > Feel free to review it. > > > > > > > > > > It can also be found at: > > > > > https://people.freebsd.org/~rmacklem/zfs-xattr.patch > > > > > (this is a smaller diff which can be applied to an up-to-date mai= n src > > > > > tree easily) > > > > > > > > Hey Rick, > > > > > > > > I applied that zfs patch, but trying pathconf(2) on a file on a ZFS > > > > dataset with xattr=3Don (which seems to be the default) returns 0. = Am I > > > > doing something wrong? > > > > > > > > =3D=3D=3D=3D BEGIN LOG =3D=3D=3D=3D > > > > hbsd-current-01[shawn]:/home/shawn/tmp $ ./xattrtest xattrtest > > > > xattrtest: Named attributes not enabled: No error: 0 > > > > hbsd-current-01[shawn]:/home/shawn/tmp (1) $ zfs list /usr/home/sha= wn > > > > NAME USED AVAIL REFER MOUNTPOINT > > > > rpool/usr/home 10.4G 71.4G 9.85G /usr/home > > > > hbsd-current-01[shawn]:/home/shawn/tmp $ zfs get xattr rpool/usr/ho= me > > > > NAME PROPERTY VALUE SOURCE > > > > rpool/usr/home xattr on default > > > > =3D=3D=3D=3D END LOG =3D=3D=3D=3D > > > > > > > > That xattrtest application is yours from: > > > > https://people.freebsd.org/~rmacklem/xattrtest.c > > > No idea. It works for me. You used up-to-date kernel sources? > > > (Check that VIRF_NAMEDATTR is defined in sys/sys/vnode.h.) > > > Oh, and one more thing to check. zfs_xattr_compat needs to be non-zer= o. > > > (It's found in sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os= =2Ec. > > > It's initialized to 1 and I don't see anything that sets it to 0?) > >=20 > > It is indeed set to 1. > >=20 > > >=20 > > > The only thing I can think if is, if you changed xattr to on, you nee= d to > > > reboot (or at least remount) to get it to take effect. > > > (Maybe try setting it to "dir" and then reboot/remount. Maybe there is > > > a difference between "on" and "dir"?) > >=20 > > Yeah, tried rebooting and still no go. Note that xattr defaults to > > "on" in FreeBSD by default. My src tree is synced up to FreeBSD commit > > 7e70d94acd68b3ac6b45f49d4ab7a0f7867c3ea7. I brought in the ZFS patch > > you linked to. > >=20 > > >=20 > > > Or, did you build zfs.ko some other way than as part of a kernel buil= d? > > > (It needs the patched .h files in the kernel sources, not something in > > > /usr/include/sys > > > that has not yet been updated.) > > > All the ZFS changes are #ifdef'd, since OpenZFS requires the sources > > > build for older kernels. (Basically #ifdef'd on that VIRF_NAMEDATTR m= entioned > > > above.) > >=20 > > Perhaps I need to do a clean build. I'll try that and report back. > >=20 > > >=20 > > > It does remind me that I need to try a build of zfs.ko by doing a "ma= ke" in > > > the module directory. > > >=20 > > > You can try the attached trivial patch and see if it spits out "pathc= onf ret=3D1" > > > on the console. > >=20 > > I'll try that after a clean rebuild of the kernel. >=20 > Clean rebuild didn't resolve it. However, I made some progress. >=20 > I created a dataset specifically for this since I can't really unmount > my /usr/home dataset, so my example down below is a bit different than > the previous example I gave. >=20 > The xattr property is set to "on" for the dataset. However, it's not > mounted with the xattr property. In order to get it to work, I had to > run the following commands: >=20 > =3D=3D=3D=3D BEGIN LOG =3D=3D=3D=3D > $ sudo zfs umount rpool/scratch/xattr > $ sudo mount -t zfs -o xattr rpool/scratch/xattr /scratch/xattr > $ zfs get xattr rpool/scratch/xattr > NAME PROPERTY VALUE SOURCE > rpool/scratch/xattr xattr on local > $ mount | grep xattr > rpool/scratch/xattr on /scratch/xattr (zfs, local, noatime, nfsv4acls, na= med attributes) > $ mount | grep named > rpool/scratch/xattr on /scratch/xattr (zfs, local, noatime, nfsv4acls, na= med attributes) > =3D=3D=3D=3D END LOG =3D=3D=3D=3D >=20 > So it looks like FreeBSD does not honor the xattr zfs property, > otherwise you would see a whole bunch of datasets mounted with the > "named attributes" flag in that last `mount | grep` command. Here's a little test program I whipped up to copy a shared object into an extended attribute, then fdlopen the attribute: https://git.hardenedbsd.org/shawn.webb/random-code/-/commit/32544bcccd29b43= c2fd70a33e0c685cebb0fdbdf It's an ugly PoC, but it works. :-) --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Signal Username: shawn_webb.74 Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50 https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --5qny3xgl73u3aeli Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmfwiRMACgkQ/y5nonf4 4frNNA/8D6TbKj6hSoSfahsByWEP5Rx0nOPfeHEaHXk0cxhJ1wtWFB/Mba0xSgs0 4l1OlIgD8QR0mnp7LHW1LwbuBFygbPeXUqIhVzoKVNeIkSLfrIZaMM9Q8oEq5vNA SNNKb9NWtp8uW17/PeQ01FJPWNKHg/eH3wICV6O/FTq4YZVVtHRNfnTBWKuSIrRV MTzOEKfPcpcxuNVMHMYPwhcSGX8nN8xBey4jjueGAZKgnLMyU1kJuTET2/1cJSfA Kod+vdI+SG65Tuzh8apdggNa6zTmBlajNLTzpgBhX/l6F89o86+uaZ82/MRHeFDS 8BClLkiLqSIOXlD3EH4JITXzgPp8kl9MnXgrkybIxn7JylKlNbAupZWLaW4V2SSO l2hyONSn1ednWcHhDQbFnxuq8GnbDiR1NxogsoELNIKJukqxdi1H4YGeCuVexvh2 Wb6jWToiz39L0Qd5zNi5c8jYeAP+HGpAI/x2xlg+/he8LqVP4Mfdu1AnpSGO3R4e 1UqCSv6B5pQuncP0tIf2QvViDaM4NknJF9lykDAiibk6vAHk9Dc4vkA6vFfR5+fl DIHiJCTRHQjACoVbcgpmPzcY2pPKMIUeKu4esBFgUfWN/npNthoPWEH+hYhLWQx3 Z+WEAJ6u0g1MoWkxxA/gdgIwrVKsPXe98Vnhcs32YTIWGwm26PM= =n6Dc -----END PGP SIGNATURE----- --5qny3xgl73u3aeli--