From owner-freebsd-apache@freebsd.org Sat Oct 7 20:59:21 2017 Return-Path: Delivered-To: freebsd-apache@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1D108E4248A for ; Sat, 7 Oct 2017 20:59:21 +0000 (UTC) (envelope-from bernard@imap.bachfreund.nl) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 4191576FA8 for ; Sat, 7 Oct 2017 20:59:20 +0000 (UTC) (envelope-from bernard@imap.bachfreund.nl) Received: by mailman.ysv.freebsd.org (Postfix) id 328C4E42489; Sat, 7 Oct 2017 20:59:20 +0000 (UTC) Delivered-To: apache@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3215DE42488 for ; Sat, 7 Oct 2017 20:59:20 +0000 (UTC) (envelope-from bernard@imap.bachfreund.nl) Received: from smtp01.qsp.nl (smtp01.qsp.nl [193.254.214.162]) by mx1.freebsd.org (Postfix) with ESMTP id 896EF76FA0 for ; Sat, 7 Oct 2017 20:59:18 +0000 (UTC) (envelope-from bernard@imap.bachfreund.nl) Received: from smtp01.qsp.nl (localhost [127.0.0.1]) by smtp01.qsp.nl (Postfix) with ESMTP id 8864B2A0CDA; Sat, 7 Oct 2017 22:53:30 +0200 (CEST) Received: from mail.brnrd.eu (unknown [193.164.217.85]) by smtp01.qsp.nl (Postfix) with ESMTP; Sat, 7 Oct 2017 22:53:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=brnrd.eu; h=date:from:to:subject:message-id; s=default; bh=IU2rbq9uoRMfF22WjMQKweWPNIuva1W/VG/+xSBiyek=; b=hQpcCD0eGVndc6bjfmMhzFL7UScBAH/l9ABhu7uaa0xT8X0baCzO80u4vGRNXtICZTdUAmPQgCLzu04f997IexYf9MHhog1RpGpo78VvuHFy3NCNQi1DLvdiFaVYDvIpwL6cj6M3YAh5/WnmznbM0KKztX+6B/auTUAmCxaVCPfLWMjw+e7I61FPbQuWhIh/6JGt4xNITKIVtOMU+sRu/xoJrnJAohh9oyutc4sdz5PVDENFll9NVs4tAOk7L0DXt4+HChMdFuHhEEIHuQlRNvUaJg/VRiwhxs2hiBejm8IU9EOlBZdUKamtL8jDQ07rvB9HLLUNfVI/ZfAWxUWxrw== Received: from mail.bachfreund.nl (http.brnrd.eu [172.17.2.8]) by bachfreund.nl (OpenSMTPD) with ESMTPSA id 4ff4bb64 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO; Sat, 7 Oct 2017 22:46:49 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 07 Oct 2017 22:46:49 +0200 From: bernard To: olli hauer Cc: apache@freebsd.org Subject: Re: Review Uses/apache.mk In-Reply-To: <18568344-3c12-61f5-0bd6-e13c8b020ca0@gmx.de> References: <18568344-3c12-61f5-0bd6-e13c8b020ca0@gmx.de> Message-ID: <5389b9c3789c99b67fefd6e0fcdce704@imap.bachfreund.nl> X-Sender: bernard@imap.bachfreund.nl User-Agent: Roundcube Webmail/1.3.1 X-SMTP-Virus-Scanned: clamav at smtp01 X-Spam-Status: No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, UNPARSEABLE_RELAY autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on svfilter04.qsp.nl X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Oct 2017 20:59:21 -0000 On 18.09.2017 21:16, olli hauer wrote: > Hi Bernard, > > sorry for the long delay. > > I've tried to see your review patch in a small test build but was not > able to apply the raw patch that can be downloaded on the review page. > > In the arc help or on the wiki I see no hint how to checkout the full > changed files for a review, is this even possible? > (I suspect I'm getting to old for such tools ...) > > Anyway I have some additional patch sleeping since a long time on my > private repo, the intention is to move the module include line from > httpd.conf to a dedicated file under modules.d. > (Perhaps APID should be renamed to MODID or something else) > https://people.freebsd.org/~ohauer/diffs/Mk__apache.mk-modules-201708.diff > > Perhaps this patch can solve the issue for users during update or > reinstalling a module where the line load is missing after reinstall > (pkg bug) or commented after upgrade. > > Additional I've read today an article about an apache issue (sorry > only in german) > https://www.golem.de/news/optionsbleed-apache-webserver-blutet-1709-130105.html > > and have shaped already the apache patch from the upstream repo. > https://people.freebsd.org/~ohauer/diffs/apache24_options_20170918.diff > > PS: > would you mind to join the apache@ team, seems you are a very good > candidate. > In case of yes pleas add your @FreeBSD nic to the wiki page > https://wiki.freebsd.org/Apache Hi Olli, Added myself to the wiki page as part of apache@. Is there anything else that needs to be arranged? Mail postmaster@ for inclusion of brnrd@ into apache@ ? I'll make the full file and the patches available on my Github and website. If you have php-arcanist installed, it should be as simple as `arc patch D12308` but I've not tried that... The patches seem worth while. The diff is becoming a bit too big I'm afraid. I've got another revision almost done, will get it to you all. In my private github: https://github.com/Sp1l/ports/commit/a6fc987f3016ca594c3b9930615e2ea4b86a6b43 As svn diff https://brnrd.eu/bsd/patch-Mk_Uses_apache.mk There's a build of all ports depending on Apache in progress on https://keg.brnrd.eu/build.html?mastername=111amd64-default&build=2017-10-07_21h38m23s The options patch apache24_options_20170918.diff was already committed I believe? Meanwhile I have a patch for 2.4.28 in bugzilla for review as well: https://bugs.freebsd.org/222814. The 2.4.28 buildlog is on https://keg.brnrd.eu/data/111amd64-default/2017-10-07_21h38m23s/logs/apache24-2.4.28.log Cheers, Bernard.