From owner-freebsd-hackers@FreeBSD.ORG  Fri Apr  8 11:48:36 2011
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E82DB1065676;
	Fri,  8 Apr 2011 11:48:36 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 05ED38FC17;
	Fri,  8 Apr 2011 11:48:35 +0000 (UTC)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
	[212.40.38.101])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id OAA05282;
	Fri, 08 Apr 2011 14:48:31 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Message-ID: <4D9EF60F.1010704@FreeBSD.org>
Date: Fri, 08 Apr 2011 14:48:31 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.2.15) Gecko/20110309 Lightning/1.0b2 Thunderbird/3.1.9
MIME-Version: 1.0
To: Garrett Cooper <yanegomi@gmail.com>
References: <4D9DF375.4080506@FreeBSD.org>	<BANLkTimAyh4-T0gQ1cuQn0nm8m7SHwW5iA@mail.gmail.com>	<20110408000025.GA16252@icarus.home.lan>
	<BANLkTimB9XmkX3V7sMg5dBLSqz=Vxz7nEQ@mail.gmail.com>
In-Reply-To: <BANLkTimB9XmkX3V7sMg5dBLSqz=Vxz7nEQ@mail.gmail.com>
X-Enigmail-Version: 1.1.2
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: freebsd-fs@FreeBSD.org, FreeBSD Hackers <freebsd-hackers@FreeBSD.org>,
	Jeremy Chadwick <freebsd@jdc.parodius.com>
Subject: Re: retry mounting with ro when rw fails
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Apr 2011 11:48:37 -0000

on 08/04/2011 05:16 Garrett Cooper said the following:
>     Yeah. It seems like something else like EINVAL (just an example --
> probably a bad one) would be better. Also, please be careful as
> returning ENODEV seems to be UFS-specific:

I wonder how you arrived at that conclusion.
See intro(2) or grep the sources.

> 
>      The following errors can occur for a ufs file system mount:
> 
>      [ENODEV]           A component of ufs_args fspec does not exist.

That documented specific use of ENODEV in UFS doesn't make ENODEV UFS-specific.
Besides I don't ENODEV anywhere under sys/ufs.

>     Also, Tom Rhodes has a similar change to what I suggested on the
> backburner, but it hasn't been 100% fleshed out yet.

I like that approach too.  It has its advantages.
But I don't give up yet on my suggestion.

-- 
Andriy Gapon