From owner-freebsd-stable@FreeBSD.ORG Fri May 10 05:23:02 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 68CE44F3 for ; Fri, 10 May 2013 05:23:02 +0000 (UTC) (envelope-from freebsd@pki2.com) Received: from btw.pki2.com (btw.pki2.com [IPv6:2001:470:a:6fd::2]) by mx1.freebsd.org (Postfix) with ESMTP id 173F2DBD for ; Fri, 10 May 2013 05:23:02 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by btw.pki2.com (8.14.6/8.14.5) with ESMTP id r4A5Mp7u051078; Thu, 9 May 2013 22:22:51 -0700 (PDT) (envelope-from freebsd@pki2.com) Subject: Re: Apparent regression in r250359 From: Dennis Glatting To: Jim Ohlstein In-Reply-To: <518BDA28.20603@ohlste.in> References: <518A880C.3090906@ohlste.in> <20130509053055.GM3047@kib.kiev.ua> <518BAEFB.5090204@ohlste.in> <20130509143038.GV3047@kib.kiev.ua> <518BC3E4.1030104@ohlste.in> <20130509160433.GW3047@kib.kiev.ua> <518BDA28.20603@ohlste.in> Content-Type: text/plain; charset="ISO-8859-1" Date: Thu, 09 May 2013 22:22:51 -0700 Message-ID: <1368163371.96389.2.camel@btw.pki2.com> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit X-yoursite-MailScanner-Information: Dennis Glatting X-yoursite-MailScanner-ID: r4A5Mp7u051078 X-yoursite-MailScanner: Found to be clean X-MailScanner-From: freebsd@pki2.com Cc: Konstantin Belousov , freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 May 2013 05:23:02 -0000 This patch allows my AMD CURRENT to complete boot without core dumping. I was also able to recompile/reinstall lang/gcc48 without trouble. My 9.1 systems are busy but I may be able to give it a try tomorrow. On Thu, 2013-05-09 at 13:17 -0400, Jim Ohlstein wrote: > On 05/09/13 12:04, Konstantin Belousov wrote: > > On Thu, May 09, 2013 at 11:42:28AM -0400, Jim Ohlstein wrote: > >> On 05/09/13 10:30, Konstantin Belousov wrote: > >>> On Thu, May 09, 2013 at 10:13:15AM -0400, Jim Ohlstein wrote: > >>>> # sysctl hw.model > >>>> hw.model: AMD FX(tm)-8350 Eight-Core Processor > >>> Ahh, so it seems that this is a CPU with the LWP. > >>> Please try the patch at the end of message. > >> > >> Same error > >> > >>> > >>> As another workaround, which does not disable AVX support, you > >>> could try loader tunable hw.xsave_mask=0x7. > >> > >> This works > > > > Hm, I see another bug in the next line as well. Could you try this > > updated patch ? > > This does work. > > > > > diff --git a/sys/amd64/amd64/fpu.c b/sys/amd64/amd64/fpu.c > > index de79baa..9bc8a2f 100644 > > --- a/sys/amd64/amd64/fpu.c > > +++ b/sys/amd64/amd64/fpu.c > > @@ -687,8 +687,8 @@ fpugetregs(struct thread *td) > > offsetof(struct xstate_hdr, xstate_bv)); > > max_ext_n = flsl(xsave_mask); > > for (i = 0; i < max_ext_n; i++) { > > - bit = 1 << i; > > - if ((*xstate_bv & bit) != 0) > > + bit = 1ULL << i; > > + if ((xsave_mask & bit) == 0 || (*xstate_bv & bit) != 0) > > continue; > > bcopy((char *)fpu_initialstate + > > xsave_area_desc[i].offset, > > > >