From owner-freebsd-current Fri Mar 3 14:31:08 1995 Return-Path: current-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.9/8.6.6) id OAA04905 for current-outgoing; Fri, 3 Mar 1995 14:31:08 -0800 Received: from hda.com (hda.com [199.232.40.182]) by freefall.cdrom.com (8.6.9/8.6.6) with ESMTP id OAA04899 for ; Fri, 3 Mar 1995 14:31:06 -0800 Received: (dufault@localhost) by hda.com (8.6.9/8.3) id RAA00210; Fri, 3 Mar 1995 17:28:44 -0500 From: Peter Dufault Message-Id: <199503032228.RAA00210@hda.com> Subject: Re: cvs commit: src/sys/scsi scsi_driver.c To: phk@ref.tfs.com (Poul-Henning Kamp) Date: Fri, 3 Mar 1995 17:28:44 -0500 (EST) Cc: current@freefall.cdrom.com In-Reply-To: <199503032141.NAA12454@ref.tfs.com> from "Poul-Henning Kamp" at Mar 3, 95 01:41:38 pm X-Mailer: ELM [version 2.4 PL24] Content-Type: text Content-Length: 962 Sender: current-owner@FreeBSD.org Precedence: bulk Poul-Henning Kamp writes: > > > > > dufault 95/03/03 13:38:44 > > > > Modified: sys/scsi scsi_driver.c > > Log: > > Make sure there is a device before opening. Fixes NULL access > > when opening unattached devices. > > > Thanks! Well, your thanks are premature. That first shot was off the cuff - now that I've thought about it that pointer can (well, should) never be NULL - all compiled in the kernel devices are initialized before trying to attach them, and that should initialize those pointers. Plus I can't demonstrate any problems by opening devices I don't have, such as the media changer. There shouldn't be any difference between that and a non-SCSI owner opening sd0d. I'll need a backtrace or a way to reproduce the problem on a system with SCSI devices. -- Peter Dufault Real Time Machine Control and Simulation HD Associates, Inc. Voice: 508 433 6936 dufault@hda.com Fax: 508 433 5267