From nobody Tue Dec 31 21:13:48 2024 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YN5LN1M1Vz5k2Vg for ; Tue, 31 Dec 2024 21:13:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YN5LM6JPWz50kl for ; Tue, 31 Dec 2024 21:13:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735679627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IZ10Klp+8B0TvqBfOsNmRR72A7ECMpZyg5iHpPIj+XU=; b=hyzt0jRTGS2419SaMFwfy0PxZK2FDdCxHyvsaNBhDUgBLJl2T9F8JhNUq79Ti1PWOnZMUL nQ5jrF+t6QJO+Tpxns+J8BwIwvntp85+6wiN7jN0f3A9+bfxULplwvI+w2z/ks69tkVcqn /8X7OwUTiAT3BTK17zrCJESaYx48f8sgOmjExRZ3zpu21m5VmZdmDxZW3vz6Ao3acuFhph 4Y5tjUa9gV69lYo71MuLoyL/ZjIcP+zn8NWzp0yxlJv3vQrXsNoMAUSHxSjWHgA8gEgipw MHHzLo+yG9ksuXEKsXcPM7KMW067EtD/ecUvVchFIKUs6qE5O5XSM/f/RmfTvQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1735679627; a=rsa-sha256; cv=none; b=PpwJK/d8Jd4+uCdgaD/V+K/V/A8u1sT++R5ASQR0hBCDhH5FOWsLrLFiZRcx4gUrjWNonT 1qDyAsOwGHnpyeR+aT+/SWIOwuiO4OSgW7FKVjCM558x87Sg3rnDsLArn6Gj1lY1jvoqtK i5aS25R+Srxkvc45mtVzJMaO6mHknuGWGG0G8rtxzmadNZlTji8yusbWzufwbB55E883Qs cizNMo+VVr00SX90Npz59vT+j6pAF1pwG+g4P6vcW4UgR+1vPKO9kjjSHOCpFHohiAKN27 ff7KfbuYdi0n3UWe8lT7rT2vmQaKSHKvHL1DFQPDMRQzGx82L98+iSWzBaQvXQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YN5LM5vlCzwbk for ; Tue, 31 Dec 2024 21:13:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4BVLDlJj092963 for ; Tue, 31 Dec 2024 21:13:47 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4BVLDlCs092962 for ports-bugs@FreeBSD.org; Tue, 31 Dec 2024 21:13:47 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 283516] textproc/ibus: update to 1.5.31 Date: Tue, 31 Dec 2024 21:13:48 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: henry.hu.sh@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-ports-bugs@freebsd.org Sender: owner-freebsd-ports-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D283516 --- Comment #1 from Henry Hu --- On the high level this looks good, I have a few comments, though: 1. I know vulkan and graphene are listed as 'requirements' in gtk4.pc. Do y= ou think that we should list them as dependencies of this port, though? This port does not use them directly; instead, they're depended upon indire= ctly through GTK4, right? So we possibly should just have GTK4 depend on them? If you check the code, actually gtk2 & gtk3 plugins also use graphene, but they're not listed. I suppose removing them creates warnings in stage-qa? I still lean towards = not having them as direct dependencies, though, at least not vulkan - we do have some code which uses graphene, although the code does not even include its header. I think the code possibly should be fixed upstream... My opinion on this is not very strong, though. If you want to keep them to avoid the warning, I'm okay with that. 2. I think removing the BUILD_DEP on gtk-doc is not fully correct; it shoul= d be there when the DOCS option is enabled, otherwise, it'll be detected as miss= ing during configure, and docs would not be built. 3. This is not relevant to this change, but it seems like that we're missin= g a bunch of html files in the pkg-plist, if the DOCS option is enabled. I don't know why we didn't notice this earlier, but we should install them,= I think. This is discovered through `make check-plist`. --=20 You are receiving this mail because: You are the assignee for the bug.=