From owner-freebsd-arch@FreeBSD.ORG Thu Mar 19 20:04:59 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 48E17654 for ; Thu, 19 Mar 2015 20:04:59 +0000 (UTC) Received: from mail-ig0-x231.google.com (mail-ig0-x231.google.com [IPv6:2607:f8b0:4001:c05::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0C395FBF for ; Thu, 19 Mar 2015 20:04:59 +0000 (UTC) Received: by igbud6 with SMTP id ud6so35307328igb.1 for ; Thu, 19 Mar 2015 13:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=SLb6lR+ADYVkohz51RTjmkxFNPzf5V0EDhYZHK41+rc=; b=DUYT6+u1/bVAgEA/fUEQpcoKx4gp/VuofujI6dGpVaaImkAoLFdnvRtDYwxE+x+Y88 11hnbguDk6B365Yk0+Dahk9uAEM8Sqa/1/tGvpGpSg9fiPzsRv5QYUNDnOE6Ad5TVJGM 6uWa7IAtHZiZ1c+iJyS19g6BHyz7KhKFpe9JqH3vouVPZw+4ijVH1ulqD4BxWrnVnBIi 5RwGajc2R2CDG5pMA6GhQAg16BRHWz/7bYZGM9nUSNQOgSO0sUTGLTI2dzx3IVhktxT8 8y6eoUJOQiqjPvz7FFVr7WqIMtOnEMvjB8anzm12Vrjlk6UV0BLZ7ffSYzArI25o5UhX cdrw== MIME-Version: 1.0 X-Received: by 10.50.36.65 with SMTP id o1mr19704703igj.32.1426795498383; Thu, 19 Mar 2015 13:04:58 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.36.17.194 with HTTP; Thu, 19 Mar 2015 13:04:58 -0700 (PDT) In-Reply-To: <7C64CB2B-3FD0-434C-A11A-2A841537220F@bsdimp.com> References: <7C64CB2B-3FD0-434C-A11A-2A841537220F@bsdimp.com> Date: Thu, 19 Mar 2015 13:04:58 -0700 X-Google-Sender-Auth: aZw9uptOYlImjtP6kjcS11AKlmA Message-ID: Subject: Re: ASLR work into -HEAD ? From: Adrian Chadd To: Warner Losh Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "freebsd-arch@freebsd.org" X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Mar 2015 20:04:59 -0000 On 19 March 2015 at 12:56, Warner Losh wrote: > >> On Mar 19, 2015, at 12:53 PM, Adrian Chadd wrote: >> >> Hi, >> >> Apparently this is done but has stalled: >> >> https://reviews.freebsd.org/D473 >> >> Does anyone have any strong objections to it landing in the tree as-is? > > There=E2=80=99s rather a lot of them specifically spelled out in the code= review. > > Many of the earlier ones were kinda blown off, so I=E2=80=99ve not been i= nclined > to take the time to re-review it. Glancing at it, I see several minor iss= ues > that should be cleaned up. Cool. Thanks for taking the time to look at it again. Shawn is in #freebsd on freenode irc, so if you/others want a more interactive review then he's there during the day. -a