From owner-svn-src-user@FreeBSD.ORG Wed Aug 24 23:41:03 2011 Return-Path: Delivered-To: svn-src-user@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8115E106566C; Wed, 24 Aug 2011 23:41:03 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from server.mypc.hu (server.mypc.hu [87.229.73.95]) by mx1.freebsd.org (Postfix) with ESMTP id 398158FC12; Wed, 24 Aug 2011 23:41:03 +0000 (UTC) Received: from server.mypc.hu (localhost [127.0.0.1]) by server.mypc.hu (Postfix) with ESMTP id DBAAC14DC171; Thu, 25 Aug 2011 01:23:02 +0200 (CEST) X-Virus-Scanned: amavisd-new at server.mypc.hu Received: from server.mypc.hu ([127.0.0.1]) by server.mypc.hu (server.mypc.hu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id z6JRI8KLBaOg; Thu, 25 Aug 2011 01:23:00 +0200 (CEST) Received: from [192.168.1.106] (catv-80-98-232-12.catv.broadband.hu [80.98.232.12]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by server.mypc.hu (Postfix) with ESMTPSA id D98A214D28DF; Thu, 25 Aug 2011 01:22:59 +0200 (CEST) Message-ID: <4E5587CF.2010309@FreeBSD.org> Date: Thu, 25 Aug 2011 01:22:55 +0200 From: Gabor Kovesdan User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:8.0a1) Gecko/20110816 Thunderbird/8.0a1 MIME-Version: 1.0 To: Andrey Chernov , src-committers@FreeBSD.ORG, svn-src-user@FreeBSD.ORG References: <201108222319.p7MNJKZ4072487@svn.freebsd.org> <20110823034416.GA7597@vniz.net> In-Reply-To: <20110823034416.GA7597@vniz.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Subject: Re: svn commit: r225093 - in user/gabor/tre-integration: contrib/tre/lib include X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Aug 2011 23:41:03 -0000 On 2011.08.23. 5:44, Andrey Chernov wrote: > On Mon, Aug 22, 2011 at 11:19:20PM +0000, Gabor Kovesdan wrote: >> Modified: user/gabor/tre-integration/include/regex.h >> ============================================================================== >> --- user/gabor/tre-integration/include/regex.h Mon Aug 22 23:15:15 2011 (r225092) >> +++ user/gabor/tre-integration/include/regex.h Mon Aug 22 23:19:20 2011 (r225093) >> @@ -110,6 +110,7 @@ typedef enum { >> #define REG_PEND (REG_UNGREEDY<< 1) >> #define REG_GNU (REG_PEND<< 1) >> #define REG_WORD (REG_GNU<< 1) >> +#define _REG_HEUR (REG_WORD<< 1) > Not a good place. Next extension flag from TRE author or POSIX will break > binary compatibility badly. It will be better to put it to the end of a > word instead or don't use this field at all (converting to another > internal function argument etc.), which is much safer. Thanks for reviewing my changes and commenting! This change was a semi-temporary solution. I'm wondering whether I should remove the underscore and consider it a normal knob as it may be useful outside TRE, however I cannot think of any concrete case. What do you exactly mean by end of a word? Still, binary compatibility will break if a new POSIX flag will be introduced because TRE already defines some extra flags. I'm not quite sure which is the best solution. Probably, I'll clean up my patches once I'm done and hopefully the TRE author will be interested in integrating my changes so I'll discuss these with him. Gabor