From nobody Sat Mar 1 04:38:41 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z4XQk2XScz5hw9g for ; Sat, 01 Mar 2025 04:38:54 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z4XQj6ZC6z3r0T for ; Sat, 01 Mar 2025 04:38:53 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qt1-x82d.google.com with SMTP id d75a77b69052e-471eb0e3536so51018391cf.3 for ; Fri, 28 Feb 2025 20:38:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kev009.com; s=google; t=1740803933; x=1741408733; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dhZQYuVAQT74LiW0PpGG4ltBoR2Yae9snPmUrkfZZkQ=; b=J1EXqLsSsatj0VU2zC89Q6GKn7Sv1PV6W3GAmkTUlkq+RweMIpPLff9HQ4MqiNVmny wtgrhSEX1nL42MLCsTPmrx4dLHYpV6Gw+vWwwtnL2t5hvSGXUX7KAFT3E+S0nBaWMS4o V1LCv3qSAxT5SBpsiIcH/lnV9jWbS5Zidze+A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740803933; x=1741408733; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dhZQYuVAQT74LiW0PpGG4ltBoR2Yae9snPmUrkfZZkQ=; b=XsVV7kv0VpSTqGz0CQps2HDx3V6IXYBaWHWVKGoKy3/Hd+4JcF5i/jrULP005jIaG+ H6L49xAFJRLy6749XY5BqaxpNkXd6t/aW8fVfJp7Gv4zQwZ28BSGGLCAwgATaApzUTHo 6+2VcXm1tBqhOf0ktqD8Yvx+yXgpInEiH88BlmaQ6ae8WINotMNk7jzlXYWw6RdFyFZf dsR1snRaBVgM/DTedvgIN/XmhTGc6rA4PHOGuIcKOHR1EEfgc4ymkMEAGUvBDlkz1mKP 8Ai7ev708x/HWknAHDyxGSg0TLuETDX1KnfuI07yK3Y9IceaofduwpePhc0RRSFUZ3qj Q9fw== X-Forwarded-Encrypted: i=1; AJvYcCVFDf2HoYAh7qzqei0RWD1PgoVRrOsiqh6q6DJdRhfmgIgWqD9LfNdduavnOUEgzlMkka0hfvuxl7zX/EkvzUvumEVS@freebsd.org X-Gm-Message-State: AOJu0YyX2fmhFLD5cE7YcJzgf88rx8YguR5KhHtRRhnKb2pNFH1obVCv rXExtDVOe6WyL6zlcdK6HX7AD1N2rdi+sy2iFlxUkWvUvOdiA3B03Mv7JVh996FkyQYvzFFtSUE NNQOAq2BFodckK+EJlo/xk12azB0tgNnf7BTe X-Gm-Gg: ASbGncsP1bEXkciQ7vHM5dCEznK046CKOtBDpAB64vmNAmha9H/JPmyHXRum3y/vhst XeCc3hh9v9FGeLqV6q4BfmIZ2vhTsp5dBag6SQ8Rou/lK2axc36DqyBhw8I2Iu3OPEimRRaQ8N9 LqbkgqwGqT0cpveTlpqwtP1vKRUUk= X-Google-Smtp-Source: AGHT+IH46mvBLegAtcZ3O6ovxoS8p5lnbKXbgdqwFHOwl4gWhsfx5W9PDaXnZXUBhaiDbRu6bPmHFxGD++SSepKQZqg= X-Received: by 2002:a05:622a:1115:b0:474:b801:d04f with SMTP id d75a77b69052e-474bc0a1fa3mr80888351cf.25.1740803933065; Fri, 28 Feb 2025 20:38:53 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202502280813.51S8DQiZ037985@gitrepo.freebsd.org> In-Reply-To: From: Kevin Bowling Date: Fri, 28 Feb 2025 21:38:41 -0700 X-Gm-Features: AQ5f1JomG_8ufV-ZZ0SmFl31lzU4rqLPkipIxFJ1Us-1h3tqNMinnnwNeaINv9A Message-ID: Subject: Re: git: 5c7087c349fc - main - ixgbe: Fix a logic error in ixgbe_read_mailbox_vf() Reviewed by: kbowling Differential Revision: https://reviews.freebsd.org/D49156 To: Kevin Lo Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4Z4XQj6ZC6z3r0T X-Spamd-Bar: ---- stable/13 needs MFC as well On Fri, Feb 28, 2025 at 7:34=E2=80=AFPM Kevin Lo wrote: > > On Fri, Feb 28, 2025 at 01:54:08AM -0700, Kevin Bowling wrote: > > > > MFC? > > Done. Thanks for reminding me. > > > On Fri, Feb 28, 2025 at 1:13???AM Kevin Lo wrote: > > > > > > The branch main has been updated by kevlo: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D5c7087c349fc1d826807aa= 1a11912c9e774e3321 > > > > > > commit 5c7087c349fc1d826807aa1a11912c9e774e3321 > > > Author: Kevin Lo > > > AuthorDate: 2025-02-28 08:12:00 +0000 > > > Commit: Kevin Lo > > > CommitDate: 2025-02-28 08:12:00 +0000 > > > > > > ixgbe: Fix a logic error in ixgbe_read_mailbox_vf() > > > Reviewed by: kbowling > > > Differential Revision: https://reviews.freebsd.org/D49156 > > > --- > > > sys/dev/ixgbe/ixgbe_mbx.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/sys/dev/ixgbe/ixgbe_mbx.c b/sys/dev/ixgbe/ixgbe_mbx.c > > > index 5f1f64e02b82..0b866e7a39af 100644 > > > --- a/sys/dev/ixgbe/ixgbe_mbx.c > > > +++ b/sys/dev/ixgbe/ixgbe_mbx.c > > > @@ -297,7 +297,7 @@ static u32 ixgbe_read_mailbox_vf(struct ixgbe_hw = *hw) > > > u32 vf_mailbox =3D IXGBE_READ_REG(hw, IXGBE_VFMAILBOX); > > > > > > vf_mailbox |=3D hw->mbx.vf_mailbox; > > > - hw->mbx.vf_mailbox |=3D vf_mailbox % IXGBE_VFMAILBOX_R2C_BITS= ; > > > + hw->mbx.vf_mailbox |=3D vf_mailbox & IXGBE_VFMAILBOX_R2C_BITS= ; > > > > > > return vf_mailbox; > > > }