From owner-cvs-all Sat Mar 23 8:53:25 2002 Delivered-To: cvs-all@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id 2D96F37B41A; Sat, 23 Mar 2002 08:53:21 -0800 (PST) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.2/8.12.2) with ESMTP id g2NGr3p1045548; Sat, 23 Mar 2002 17:53:04 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Bruce Evans Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys disklabel.h In-Reply-To: Your message of "Sun, 24 Mar 2002 03:48:58 +1100." <20020324032036.T39700-100000@gamplex.bde.org> Date: Sat, 23 Mar 2002 17:53:03 +0100 Message-ID: <45547.1016902383@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20020324032036.T39700-100000@gamplex.bde.org>, Bruce Evans writes: >On Sat, 23 Mar 2002, Poul-Henning Kamp wrote: > >> phk 2002/03/23 08:03:13 PST >> >> Modified files: >> sys/sys disklabel.h >> Log: >> Hide the ugly d_boot[01] from the kernel. >> >> Revision Changes Path >> 1.71 +4 -0 src/sys/sys/disklabel.h > >This reintroduces the alignment/padding problems that were fixed by >removing the corresponding hiding in rev.1.35. It typically makes >"struct disklabel" smaller in userland than in the kernel on 64-bit >machines. E.g., on alphas, the struct size was 280 in both places, >but this change makes it 276 in the kernel. It would be much more >fatal on machines with 128-bit alignment requirements for pointers >or 128-bit pointers since then d_boot[01] would not be naturally >aligned and/or would take more space than d_packname. Argh, damn. Didn't think of the alignment. Backing out. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message