From owner-freebsd-gnome Sat Jan 19 8:49:37 2002 Delivered-To: freebsd-gnome@freebsd.org Received: from sushi.sanyusan.se (h12n2fls34o835.telia.com [213.67.31.12]) by hub.freebsd.org (Postfix) with ESMTP id 8699F37B405 for ; Sat, 19 Jan 2002 08:49:34 -0800 (PST) Received: (from anders@localhost) by sushi.sanyusan.se (8.11.6/8.11.6) id g0JGnNQ24683; Sat, 19 Jan 2002 17:49:23 +0100 (CET) (envelope-from anders) Date: Sat, 19 Jan 2002 17:49:23 +0100 From: Anders Andersson To: Joe Clarke Cc: gnome@FreeBSD.ORG Subject: Re: deskutils/gnomepim Message-ID: <20020119164923.GC20216@sushi.sanyusan.se> References: <20020119162813.GA25897@sushi.sanyusan.se> <1011458564.62255.3.camel@shumai.marcuscom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1011458564.62255.3.camel@shumai.marcuscom.com> User-Agent: Mutt/1.3.26i Sender: owner-freebsd-gnome@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Jan 19, 2002 at 11:42:43AM -0500, Joe Clarke wrote: > On Sat, 2002-01-19 at 11:28, Anders Andersson wrote: > > It seems that the expected result is inverted in gnomepim's Makefile. > > > > If I define WITHOUT_PILOT then it builds gnomepim with pilot support and > > if I dont define WITHOUT_PILOT it happily builds without pilot-link and > > so on. > > > > I will look at the Makefile to see if I have missed a studpid tweak or > > not. > > You're absolutely right. The Makefile should read: > > .if !defined(WITHOUT_PILOT) > BUILD_DEPENDS= > ${X11BASE}/lib/gnome-pilot/conduits/libemail_conduit.so:${PORTSDIR}/palm/gnomepilot-conduits > RUN_DEPENDS= > ${X11BASE}/lib/gnome-pilot/conduits/libemail_conduit.so:${PORTSDIR}/palm/gnomepilot-conduits > .endif > > But instead will add the depends when you _do_ define WITHOUT_PILOT. Of > course, it goes on to do the right thing in other places, so this may > break the port. > > The attached patch should fix things. Hah, I cant belive I missed that '!' I will try this and report back if I find any problems. -- Anders Andersson UNIX, Networking and Security consultant +46 (0)705 87 53 35 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-gnome" in the body of the message