Date: Mon, 11 Apr 2016 13:53:34 +0800 From: Sepherosa Ziehau <sephe@freebsd.org> To: Ravi Pokala <rpokala@mac.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r297802 - head/sys/dev/hyperv/vmbus Message-ID: <CAMOc5cwh63SVB%2BpNpQ6J974LedrvYp3fQViMCwZkwRFUU_L=yw@mail.gmail.com> In-Reply-To: <0FE57290-DFEA-4524-9A46-9532643BB9FA@panasas.com> References: <201604110328.u3B3SI9e070348@repo.freebsd.org> <0FE57290-DFEA-4524-9A46-9532643BB9FA@panasas.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Yeah, sure. On Mon, Apr 11, 2016 at 1:23 PM, Ravi Pokala <rpokala@mac.com> wrote: > Hi sephe, > > > > -----Original Message----- > From: <owner-src-committers@freebsd.org> on behalf of Sepherosa Ziehau <sephe@FreeBSD.org> > Date: 2016-04-10, Sunday at 20:28 > To: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org> > Subject: svn commit: r297802 - head/sys/dev/hyperv/vmbus > >>Author: sephe >>Date: Mon Apr 11 03:28:17 2016 >>New Revision: 297802 >>URL: https://svnweb.freebsd.org/changeset/base/297802 >> >>Log: >> hyperv: Identify Hyper-V features and recommends properly >> >> Features bits will be used to detect devices, e.g. timers, which >> do not have corresponding event channels. >> >> ... >> >>+ op = HV_CPU_ID_FUNCTION_HV_INTERFACE; >>+ do_cpuid(op, regs); >>+ if (regs[0] != 0x31237648 /* HV#1 */) >>+ return (false); > > Could you make that a #defined constant, rather than a magic integer? > > Thanks, > > Ravi (rpokala@) > -- Tomorrow Will Never Die
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMOc5cwh63SVB%2BpNpQ6J974LedrvYp3fQViMCwZkwRFUU_L=yw>