From owner-freebsd-net@FreeBSD.ORG  Fri Apr 20 06:29:58 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EA57C1065670
	for <net@freebsd.org>; Fri, 20 Apr 2012 06:29:58 +0000 (UTC)
	(envelope-from bz@FreeBSD.org)
Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25])
	by mx1.freebsd.org (Postfix) with ESMTP id 757C48FC15
	for <net@freebsd.org>; Fri, 20 Apr 2012 06:29:58 +0000 (UTC)
Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587])
	(using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.sbone.de (Postfix) with ESMTPS id 7625A25D39FD;
	Fri, 20 Apr 2012 06:29:57 +0000 (UTC)
Received: from content-filter.sbone.de (content-filter.sbone.de
	[IPv6:fde9:577b:c1a9:31::2013:2742])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.sbone.de (Postfix) with ESMTPS id B11D9BE5399;
	Fri, 20 Apr 2012 06:29:56 +0000 (UTC)
X-Virus-Scanned: amavisd-new at sbone.de
Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587])
	by content-filter.sbone.de (content-filter.sbone.de
	[fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024)
	with ESMTP id j07Fu4GtNDeG; Fri, 20 Apr 2012 06:29:55 +0000 (UTC)
Received: from orange-en1.sbone.de (orange-en1.sbone.de
	[IPv6:fde9:577b:c1a9:31:cabc:c8ff:fecf:e8e3])
	(using TLSv1 with cipher AES128-SHA (128/128 bits))
	(No client certificate requested)
	by mail.sbone.de (Postfix) with ESMTPSA id A8D70BE539B;
	Fri, 20 Apr 2012 06:29:55 +0000 (UTC)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: "Bjoern A. Zeeb" <bz@FreeBSD.org>
In-Reply-To: <280454D9-E233-4010-8810-588296FA19D1@neville-neil.com>
Date: Fri, 20 Apr 2012 06:29:54 +0000
Content-Transfer-Encoding: quoted-printable
Message-Id: <8C579D33-72F0-4E82-AD93-CA7BBA3531A8@FreeBSD.org>
References: <280454D9-E233-4010-8810-588296FA19D1@neville-neil.com>
To: George Neville-Neil <gnn@neville-neil.com>
X-Mailer: Apple Mail (2.1084)
Cc: net@freebsd.org
Subject: Re: Question about fixing udp6_input...
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Apr 2012 06:29:59 -0000


On 20. Apr 2012, at 01:44 , George Neville-Neil wrote:

> Howdy,
>=20
> At the moment the prototype for udp6_input() is the following:
>=20
> int
> udp6_input(struct mbuf **mp, int *offp, int proto)
>=20
> and udp_input() looks like this:
>=20
> void
> udp_input(struct mbuf *m, int off)
>=20
> As far as I can tell we immediately change **mp to *m and *offp to off
> in udp6_input() and we also never use proto in the rest of the =
function.
>=20
> Is there any reason to not make udp6_input() look exactly like =
udp_input() ?

I think the answer to this is here:

http://wiki.freebsd.org/IPv6TODO#Remove_ip6protosw

--=20
Bjoern A. Zeeb                                 You have to have visions!
   It does not matter how good you are. It matters what good you do!