From owner-svn-src-all@freebsd.org Fri Jan 20 07:00:25 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 83CF3CB9661; Fri, 20 Jan 2017 07:00:25 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "anubis.delphij.net", Issuer "StartCom Class 1 DV Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 668B71D71; Fri, 20 Jan 2017 07:00:25 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from Xins-MBP.ut.rhv.delphij.net (unknown [IPv6:2601:646:8882:752a:389e:e35e:c4a4:70e1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by anubis.delphij.net (Postfix) with ESMTPSA id 1BAEA2B96F; Thu, 19 Jan 2017 23:00:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=delphij.net; s=anubis; t=1484895625; x=1484910025; bh=1RHS7DyETlhMmgNXz6mHk2FZ7muuwMIqvPjO0HOzrHk=; h=Subject:To:References:Cc:From:Date:In-Reply-To; b=4QaKLDrLr3ImMJSz8d5XUEl1udu2xnYKBk5mmgB3SBymHbS3FC33+7tghsjq3hQ0D AQEZAmLF18JSYvVcsFtsCOe3C87R2P2nwuCsNzftVZe4BqdLvNQZmGylQQy1jC4RE4 JD8+EepjPxbfAsBfIsOA0ldkw6WQZzqcA8mQHDiU= Subject: Re: svn commit: r312404 - head/usr.bin/sed To: Antoine Brodin , Xin LI References: <201701190801.v0J81ZG9008267@repo.freebsd.org> Cc: d@delphij.net, src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Xin Li Message-ID: <9ef03812-a23a-8cd0-d8a1-1568c468e882@delphij.net> Date: Thu, 19 Jan 2017 23:00:24 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SENJsW1H2Ed9QTL5T1dRhBvn3lc1L4fWC" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2017 07:00:25 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SENJsW1H2Ed9QTL5T1dRhBvn3lc1L4fWC Content-Type: multipart/mixed; boundary="d44b1ivlC1HxeatqxGkS12JbgLghNw6LD"; protected-headers="v1" From: Xin Li To: Antoine Brodin , Xin LI Cc: d@delphij.net, src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <9ef03812-a23a-8cd0-d8a1-1568c468e882@delphij.net> Subject: Re: svn commit: r312404 - head/usr.bin/sed References: <201701190801.v0J81ZG9008267@repo.freebsd.org> In-Reply-To: --d44b1ivlC1HxeatqxGkS12JbgLghNw6LD Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 1/19/17 22:29, Antoine Brodin wrote: > On Thu, Jan 19, 2017 at 9:01 AM, Xin LI wrote: >> Author: delphij >> Date: Thu Jan 19 08:01:35 2017 >> New Revision: 312404 >> URL: https://svnweb.freebsd.org/changeset/base/312404 >> >> Log: >> Use S_ISREG instead of manual & (also it's better to compare the >> result from & and the pattern instead of just assuming it's one bit >> value). >> >> Pointed out by Tianjie Mao . >> >> MFC after: 2 weeks >> Differential Revision: https://reviews.freebsd.org/D4827 >=20 > Hi, >=20 > sed -i no longer works on symlinks which breaks lots of ports. > Please revert and request an exp-run. Done. Requested as bug 216309. Cheers, --d44b1ivlC1HxeatqxGkS12JbgLghNw6LD-- --SENJsW1H2Ed9QTL5T1dRhBvn3lc1L4fWC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJYgbWIAAoJEJW2GBstM+nsil8P/2thGy73XAVRt6DFZmMMmCMy 5nRtCP9bqdBdEqVw6Xfu5/lyymhaH7oGgXiTQ8hGRKOGIvs0tGjTCr1MX23O8xkC Rp+M3JJVXNU82vidTgWeq6udiGOJ4VDTcRxvKna11LwakqDqgAVcUn3R+U7X+m/s hg2NXkEzyRWkB8qEgdTBGbW/YmHF8MFxKXuv/iV+TxlnyRFqI/JLHvSlS9MTGDri SczzIVZmkcO8vqWgPOxHB8AxYsUQu/g00BbIe7abvebYguDnnt6EUNnQJGVV9OVl jP1i8m4Yh09KxzFaJdEZL8Ld6AatBe2Gl3zRWByEKAlzFTnj0ELTD6z/gU7rmzry R38WBplt3GCHvNgjuUhZ9uiI+v7kkgchJHSHJbm9GCgpKovzm/1j41TSzHhC9p3w LXeIzIyyC0hIRJd/ThwVioIpxI44c0ZyW3xfy2x/oiMU89CZbK9272fr7rrrfFmK C4RMMu+xzNZHYgYz1UCAlmec4UOeq3IWl4/eRLabcaeKqbRbN6DaExxPLafaRxzw UNZQWxK4kigX5tNe1xzDDhHnmthFjj9AFCFtyRbJ7Yj4MB1eQurffam64yK9jJau woyBXn+CuH55ldf5o8fmOEvO0uGsWMv+TW/em9ctDD9sYIDM8pL2SlxQ+oX7v4y/ S0iYm/1+QtaJlfaXT5Mm =dTzG -----END PGP SIGNATURE----- --SENJsW1H2Ed9QTL5T1dRhBvn3lc1L4fWC--