From owner-freebsd-threads@FreeBSD.ORG Thu Dec 29 09:20:05 2005 Return-Path: X-Original-To: freebsd-threads@hub.freebsd.org Delivered-To: freebsd-threads@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 211E516A428 for ; Thu, 29 Dec 2005 09:20:05 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id F1B0843D4C for ; Thu, 29 Dec 2005 09:20:03 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id jBT9K37w082979 for ; Thu, 29 Dec 2005 09:20:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id jBT9K3Jj082978; Thu, 29 Dec 2005 09:20:03 GMT (envelope-from gnats) Resent-Date: Thu, 29 Dec 2005 09:20:03 GMT Resent-Message-Id: <200512290920.jBT9K3Jj082978@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-threads@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Kostik Belousov Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 33AB416A41F for ; Thu, 29 Dec 2005 09:15:36 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9AC1543D53 for ; Thu, 29 Dec 2005 09:15:35 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id jBT9FZiU039596 for ; Thu, 29 Dec 2005 09:15:35 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id jBT9FZ5M039595; Thu, 29 Dec 2005 09:15:35 GMT (envelope-from nobody) Message-Id: <200512290915.jBT9FZ5M039595@www.freebsd.org> Date: Thu, 29 Dec 2005 09:15:35 GMT From: Kostik Belousov To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Cc: Subject: threads/91044: [patch] ps reports zombie process as having RE state, shall be Z X-BeenThere: freebsd-threads@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Threading on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Dec 2005 09:20:05 -0000 >Number: 91044 >Category: threads >Synopsis: [patch] ps reports zombie process as having RE state, shall be Z >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-threads >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Dec 29 09:20:03 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Kostik Belousov >Release: 6.0-STABLE >Organization: - >Environment: FreeBSD deviant.kiev.zoral.com.ua 6.0-STABLE FreeBSD 6.0-STABLE #34: Wed Nov 2 11:48:22 EET 2005 root@deviant.kiev.zoral.com.ua:/usr/obj/usr/src/sys/DEVIANT i386 >Description: Revision 1.232 of the sys/kern/kern_proc.c introduced fill_kinfo_thread and fill_kinfo_proc_only separation for sysctl reporting process data. This introduced the buglet where SZOMB status for zombie processes filled in the fk_proc_only, and overwritten in the fk_thread with SIDL. As result, zombies are reported as live processes. I propose the attached patch to put them in the grave in the ps output. >How-To-Repeat: do a ps auxww and watch for zombies >Fix: Index: sys/kern/kern_proc.c =================================================================== RCS file: /usr/local/arch/ncvs/src/sys/kern/kern_proc.c,v retrieving revision 1.235 diff -u -r1.235 kern_proc.c --- sys/kern/kern_proc.c 13 Nov 2005 13:27:44 -0000 1.235 +++ sys/kern/kern_proc.c 29 Dec 2005 09:08:42 -0000 @@ -789,6 +789,8 @@ } else { kp->ki_stat = SWAIT; } + } else if (p->p_state == PRS_ZOMBIE) { + kp->ki_stat = SZOMB; } else { kp->ki_stat = SIDL; } >Release-Note: >Audit-Trail: >Unformatted: