From nobody Sun Sep 22 09:36:52 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XBLcP2nwXz5WdwP; Sun, 22 Sep 2024 09:36:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XBLcP0fpDz4TKf; Sun, 22 Sep 2024 09:36:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1726997813; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=31vzbtrRlY06D4u9n+yzIBafFG/2BgiG1Emxb//9esY=; b=Ids3Oly0UtDF0JK49Qk42CpUTxkX0alVk/cwDQPp5/uY2NMpJU4QleCi8GGhl2qUsySfvm h0s9V6TbaXit3Kd6NPu7W25QZI7IT0xyXdjWeirKiQa0LPLo1llLx938pjZzFyEWyRbuNI xSpQHV0fcXf/Z/tIy3ng3JqFpdiWLSzd/1zasl0qatdNFKvLBH1rYWgBD9sboK0rXnIRIs Pa6F+vkMQ4eNBye1Fo4F+dar5Qy3Ow3ZoziB8vzQXK7wlT48vWCMNz0wF60ClbnwLkv/+p JQWCAKTzmKM78qDf5A6lvyknemRyu1h2R7hw1bLK5/f+cSsTaWUxQjIThKIAoQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1726997813; a=rsa-sha256; cv=none; b=eGZT9Qpngyrvu4xqp9X9Mv5drstbGiQvPJ4ZTRsPTHe8Ghzj1yrHfA8BLO6FE0ZazCOV3G HcLLgf6zEK0aXTS73Hj4MMFHs2ZdN3xnmXEQCsmJCSjArcC1Zw4IRLRvPn7BIGCuLnBS8J DVhdQ4eQI2gsY9mrNCWs2WQ9YaDL2Z9v7WzDoMRZEgMbR8UqxLCfe+7uCuQ5wmTeoexivy gskRaJoGHfP5Az86Bf+KLNspnGg5o0m0ICDopIAkMNmXPnakVp6dXM3G0xPrdtOrIL7esf 99coCOsRA4A9Fd0TkB6q+01PjIiPJEadeLhHdblxlrBrGcPszTWXP6DRnwMmqw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1726997813; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=31vzbtrRlY06D4u9n+yzIBafFG/2BgiG1Emxb//9esY=; b=rHU/hyP/Yci1VRe/KwWoD8vV9qxY0JEjbDamx7MjJ9zeHhL5ZX0IiyA5+x+PXjSwSOrPhw MdcyZCAx/W3VUTPGEELl44hqniXHg8NQ0LyrWAFnBZrTZzK9n8R9Z6FBmuRShaurae/IkI 3JGpEGrjpM1Z0NBBrUFci4J8D0Tp96qYg+bdMj48vg+6ihPa9XTr4Y4g29TbO3jQnirMiA rcW0feP2VSRpZftbdbROLOdixCdn4DdR2kDH2/JybLPZSdKH5T0+NHgRQrXjf8VhMEba7D 9EBL+IVALInuNnHQtWAkWoor7xIHk/j+Q9IZXqWuHTg+5HlF7vjM3ptzNHoUQw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XBLcP0GkKz19xM; Sun, 22 Sep 2024 09:36:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 48M9aqt2000891; Sun, 22 Sep 2024 09:36:52 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 48M9aqCK000888; Sun, 22 Sep 2024 09:36:52 GMT (envelope-from git) Date: Sun, 22 Sep 2024 09:36:52 GMT Message-Id: <202409220936.48M9aqCK000888@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Konstantin Belousov Subject: git: d9259de0a623 - stable/14 - softdep_mount: report failure of the softdepflush thread creation List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: d9259de0a6232b1a28787add531cc6627718768d Auto-Submitted: auto-generated The branch stable/14 has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=d9259de0a6232b1a28787add531cc6627718768d commit d9259de0a6232b1a28787add531cc6627718768d Author: Konstantin Belousov AuthorDate: 2024-09-15 08:06:31 +0000 Commit: Konstantin Belousov CommitDate: 2024-09-21 21:19:50 +0000 softdep_mount: report failure of the softdepflush thread creation PR: 281511 (cherry picked from commit 4b273a7fb9e6d9a006c5ac7cbd27f5d006569edb) --- sys/ufs/ffs/ffs_softdep.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/sys/ufs/ffs/ffs_softdep.c b/sys/ufs/ffs/ffs_softdep.c index 90f37c2c1ac3..3729d67d1eb2 100644 --- a/sys/ufs/ffs/ffs_softdep.c +++ b/sys/ufs/ffs/ffs_softdep.c @@ -2646,10 +2646,18 @@ softdep_mount(struct vnode *devvp, ACQUIRE_LOCK(ump); ump->softdep_flags |= FLUSH_STARTING; FREE_LOCK(ump); - kproc_kthread_add(&softdep_flush, mp, &bufdaemonproc, + error = kproc_kthread_add(&softdep_flush, mp, &bufdaemonproc, &ump->softdep_flushtd, 0, 0, "softdepflush", "%s worker", mp->mnt_stat.f_mntonname); ACQUIRE_LOCK(ump); + if (error != 0) { + printf("%s: failed to start softdepflush thread: %d\n", + mp->mnt_stat.f_mntonname, error); + ump->softdep_flags &= ~FLUSH_STARTING; + FREE_LOCK(ump); + softdep_unmount(mp); + return (error); + } while ((ump->softdep_flags & FLUSH_STARTING) != 0) { msleep(&ump->softdep_flushtd, LOCK_PTR(ump), PVM, "sdstart", hz / 2);