From owner-freebsd-arch@FreeBSD.ORG Fri Oct 29 13:44:56 2010 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 71CF81065674; Fri, 29 Oct 2010 13:44:56 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 3E1398FC21; Fri, 29 Oct 2010 13:44:56 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id C535446B37; Fri, 29 Oct 2010 09:44:55 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id DA5648A009; Fri, 29 Oct 2010 09:44:54 -0400 (EDT) From: John Baldwin To: freebsd-arch@freebsd.org Date: Fri, 29 Oct 2010 09:21:03 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100819; KDE/4.4.5; amd64; ; ) References: <20101028205815.GF46314@acme.spoerlein.net> In-Reply-To: <20101028205815.GF46314@acme.spoerlein.net> MIME-Version: 1.0 Message-Id: <201010290921.03397.jhb@freebsd.org> Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Fri, 29 Oct 2010 09:44:54 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.9 required=4.2 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx Cc: Attilio Rao , Ulrich =?iso-8859-1?q?Sp=F6rlein?= Subject: Re: [PATCH] Headers for the x86 subtree X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Oct 2010 13:44:56 -0000 On Thursday, October 28, 2010 4:58:15 pm Ulrich Sp=F6rlein wrote: > On Wed, 27.10.2010 at 16:56:06 +0200, Attilio Rao wrote: > > This patch should convert a (simple and 100% shared between amd64 and > > i386 header) under the x86 sub-tree. Please note that in this patch I > > "svn cp" the file from sys/amd64/include/mptable.h into > > sys/x86/include/mptable.h: > > http://www.freebsd.org/~attilio/headers-x86.diff > >=20 > > This is someway a POC, that I really want to get in. The idea is > > simple and someway follows the pc98 case (even if not entirely): the > > files under machine/include/* became just mere stubs for x86/include/* > > contents and redirect there. > > This won't particulary help reducing the number of available files, > > but generally removing verbatim and would also be the way to go for > > handling MFCs. > > If you find this is the right way I'll commit the fix and start moving > > other files as time permits. >=20 > What I don't quite get with the new x86 directory is, why we didn't make > it arch/x86 from the start? The usual argument against moving > architecture specific stuff to arch/ is that it will break diffs for > vendors. Now with x86 and the merging we are breaking their stuff > anyway, but we don't actually improve the clutter under /sys and even > gain a new arch-specific dir, not under arch/ >=20 > Somehow, this seems like a missed opportunity for an often requested > cleanup. :/ Because you'd need to move all the architectures to be consistent. Also, t= he=20 point of 'x86' is that there are a lot of bits that are shared between i386= =20 and amd64. Prior to 'x86' many of that code was simply duplicated making i= t=20 harder to maintain. The goal of an 'x86' arch is to be a repository for co= de=20 shared between i386 and amd64. Note that both Linux and NetBSD have adopte= d a=20 similar model for code shared between i386 and amd64. =2D-=20 John Baldwin