From owner-cvs-all@FreeBSD.ORG Thu Nov 17 18:11:58 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7021C16A41F; Thu, 17 Nov 2005 18:11:58 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0BEE043D45; Thu, 17 Nov 2005 18:11:57 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.3/8.13.3) with ESMTP id jAHIBv4r026092; Thu, 17 Nov 2005 10:11:57 -0800 (PST) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.3/8.13.3/Submit) id jAHIBvvR026091; Thu, 17 Nov 2005 10:11:57 -0800 (PST) (envelope-from jmg) Date: Thu, 17 Nov 2005 10:11:56 -0800 From: John-Mark Gurney To: Hartmut Brandt Message-ID: <20051117181156.GA885@funkthat.com> References: <200511171219.jAHCJJw6079767@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200511171219.jAHCJJw6079767@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/rpc.lockd kern.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Nov 2005 18:11:58 -0000 Hartmut Brandt wrote this message on Thu, Nov 17, 2005 at 12:19 +0000: > harti 2005-11-17 12:19:19 UTC > > FreeBSD src repository > > Modified files: > usr.sbin/rpc.lockd kern.c > Log: > When a user is in more than 16 groups the call to authunix_create() will > result in abort() beeing called. This is because there is a limit of > the number of groups in the RPC which is 16. When the actual number of > groups is too large it results in xdr_array() returning an error which, > in turn, authunix_create() handles by just calling abort(). > > Fix this by passing only the first 16 groups to authunix_create(). Can't this cause problems with files that have a mode of 0604? Since normally the user would be unable to read it, but if the group gets dropped, then he is now able to access or lock the file? I don't know what the groups are used, but silently dropping groups sounds bad to me... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."