From owner-svn-src-stable@freebsd.org Mon Apr 9 15:01:41 2018 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 13F4CF86D24; Mon, 9 Apr 2018 15:01:41 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: from mail-lf0-f41.google.com (mail-lf0-f41.google.com [209.85.215.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7338C6F2C7; Mon, 9 Apr 2018 15:01:40 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: by mail-lf0-f41.google.com with SMTP id j20-v6so7048509lfk.2; Mon, 09 Apr 2018 08:01:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=EsbbcdfpoboM9UAp9VJ/39H7uKzH5FQSUqR5l+l+MuY=; b=N0CNpypBuGgCg6g1v3eZpia0uhEKOBb/s6jDwD4C+tfUnXACoAxfAFssR5AtLq/HZP i87fC/KQUz8YhCLtfgPcwC6d/RxBk1NpPoq4le5gwFRM8+dtqhqrn9cY7oFtqZW6MlBG /TBVVLpsVGJpIr5T5M8XEwUcJr4pQ802QrQDWnFCdB4jG1Mw8sclyGKxFanq2BWwVaxf EjKVfk0xiWI/84p/0hrLPjN8JBVaDJFQKmMnxi9boq41DQz0ZvDQIJNoMxR5XL+u662j 2bVYuKSUaKNuSl2YQ0/ebgdQ9jpKusp4enErTed+BL31PzR5lHQv9R6Cp8mHndvucfPr 2WmQ== X-Gm-Message-State: ALQs6tB2g7jYYGuFw1tUhxSgbgnM3fB8xtsO13sDjCssdvKNvB4MjhD1 asCw/ZCrfJqKASChHWvyUVzZrqgx X-Google-Smtp-Source: AIpwx48fxevyK97vlp5oUqAJM+ISLsxOaATkuwFv/M9rUUwvVLp/x4of8kMY/KxZiLOPKMNHZO7T6Q== X-Received: by 2002:a19:511d:: with SMTP id f29-v6mr22014707lfb.39.1523285754323; Mon, 09 Apr 2018 07:55:54 -0700 (PDT) Received: from mail-lf0-f53.google.com (mail-lf0-f53.google.com. [209.85.215.53]) by smtp.gmail.com with ESMTPSA id g22sm100318lje.36.2018.04.09.07.55.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Apr 2018 07:55:54 -0700 (PDT) Received: by mail-lf0-f53.google.com with SMTP id c78-v6so7008465lfh.1; Mon, 09 Apr 2018 07:55:54 -0700 (PDT) X-Received: by 10.46.128.132 with SMTP id i4mr22397396ljg.51.1523285753944; Mon, 09 Apr 2018 07:55:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.46.129.90 with HTTP; Mon, 9 Apr 2018 07:55:33 -0700 (PDT) In-Reply-To: <201804091446.w39EkKdr019017@pdx.rh.CN85.dnsmgr.net> References: <9cfe34fc-196a-df96-7eaf-036cc4c17bdd@daemonic.se> <201804091446.w39EkKdr019017@pdx.rh.CN85.dnsmgr.net> From: Kyle Evans Date: Mon, 9 Apr 2018 09:55:33 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r331880 - stable/11/etc To: "Rodney W. Grimes" Cc: Niclas Zeising , svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers , svn-src-stable-11@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2018 15:01:41 -0000 On Mon, Apr 9, 2018 at 9:46 AM, Rodney W. Grimes wrote: >> On 04/02/18 17:39, Rodney W. Grimes wrote: >> >> Author: kevans >> >> Date: Mon Apr 2 15:28:48 2018 >> >> New Revision: 331880 >> >> URL: https://svnweb.freebsd.org/changeset/base/331880 >> >> >> >> Log: >> >> MFC r328331: Support configuring arbitrary limits(1) for any rc.conf daemon >> >> >> >> Usage is ${name}_limits, and the argument is any flags accepted by >> >> limits(1), such as `-n 100' (e.g. only allow 100 open files). >> >> >> >> Modified: >> >> stable/11/etc/rc.subr >> >> Directory Properties: >> >> stable/11/ (props changed) >> >> >> >> Modified: stable/11/etc/rc.subr >> >> ============================================================================== >> >> --- stable/11/etc/rc.subr Mon Apr 2 15:07:41 2018 (r331879) >> >> +++ stable/11/etc/rc.subr Mon Apr 2 15:28:48 2018 (r331880) >> >> @@ -773,6 +773,8 @@ check_startmsgs() >> >> # >> >> # ${name}_login_class n Login class to use, else "daemon". >> >> # >> >> +# ${name}_limits n limits(1) to apply to ${command}. >> >> +# >> > >> > Caution, limits(1) is in /usr/bin, this code can fail if used before >> > /usr is mounted. (Ie, our rc.initdiskless) is probably broken by >> > this change if a call is made to limits. >> > >> > >> >> Sorry for jumping on this so late. This is also an issue in CURRENT, >> and has been since at least 2016. > > I was aware that it was an issue and why I made a comment about it > being MFC'ed. Though I had forgot a bug report existed. I'm kind of surprised we haven't had more complaints about this- the original commit for this stuff landed before stable/11 was even branched, so it's been broken for all of 11.x's lifetime. >> See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206291 > > This bug is rat holed as it has no FreeBSD-foo@ in the cc list. > > > -- > Rod Grimes rgrimes@freebsd.org >