From owner-cvs-all@FreeBSD.ORG Fri Jan 23 12:44:34 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6A7D816A4CE; Fri, 23 Jan 2004 12:44:34 -0800 (PST) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 548EB43D6E; Fri, 23 Jan 2004 12:44:27 -0800 (PST) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id i0NKiR0B095152; Fri, 23 Jan 2004 12:44:27 -0800 (PST) (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.10/8.12.10/Submit) id i0NKiRmu095151; Fri, 23 Jan 2004 12:44:27 -0800 (PST) (envelope-from rwatson) Message-Id: <200401232044.i0NKiRmu095151@repoman.freebsd.org> From: Robert Watson Date: Fri, 23 Jan 2004 12:44:27 -0800 (PST) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_jail.c src/sys/sys _task.h jail.h taskqueue.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jan 2004 20:44:34 -0000 rwatson 2004/01/23 12:44:27 PST FreeBSD src repository Modified files: sys/kern kern_jail.c sys/sys jail.h taskqueue.h Added files: sys/sys _task.h Log: Defer the vrele() on a jail's root vnode reference from prison_free() to a new prison_complete() task run by a task queue. This removes a requirement for grabbing Giant in crfree(). Embed the 'struct task' in 'struct prison' so that we don't have to allocate memory from prison_free() (which means we also defer the FREE()). With this change, I believe grabbing Giant from crfree() can now be removed, but need to check the uidinfo code paths. To avoid header pollution, move the definition of 'struct task' to _task.h, and recursively include from taskqueue.h and jail.h; much preferably to all files including jail.h picking up a requirement to include taskqueue.h. Bumped into by: sam Reviewed by: bde, tjr Revision Changes Path 1.35 +22 -6 src/sys/kern/kern_jail.c 1.1 +54 -0 src/sys/sys/_task.h (new) 1.19 +3 -1 src/sys/sys/jail.h 1.10 +1 -16 src/sys/sys/taskqueue.h