From owner-cvs-src@FreeBSD.ORG Mon Nov 26 19:50:25 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5164216A420 for ; Mon, 26 Nov 2007 19:50:25 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.190]) by mx1.freebsd.org (Postfix) with ESMTP id B948313C4CE for ; Mon, 26 Nov 2007 19:50:24 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: by nf-out-0910.google.com with SMTP id b2so800358nfb for ; Mon, 26 Nov 2007 11:50:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=ibhcOv7XGEZDdC4hu+Q5Kccm6r6li+PYptat7ebz8ng=; b=Stqv8v9GnIaWAIXdVWeNh30LxxRMRvFajOnD5+dmnQ/yfXID9v/WK/jn2v9mq10tds5HfJtOz3tBfq4X3vLMMKtjpjwQ7BSRbr85h1onRJ4E4HYo6LzfVonF5AmNugoPG8NMNDLYJSF3kXx318+g09cM4qUx1j7qb81NCPCzAs8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=j9JnE4PumY5o0bF6e/njeNuo+h4qRkm8XFllt8PybaJwz9SBu26yJ+2Gxsle17R1JZJjPc/bBZUUm3AWcZxaUvKACRNeYo9ET84r8LCbp5Vhs8l6Kmpfz6Gt4fu1+vMbXvAvU972jDfkU4g9dHoH5eVGzoexe5GY3iAwk1M+fTo= Received: by 10.86.78.4 with SMTP id a4mr3055273fgb.1196106622832; Mon, 26 Nov 2007 11:50:22 -0800 (PST) Received: by 10.86.28.19 with HTTP; Mon, 26 Nov 2007 11:50:22 -0800 (PST) Message-ID: <3bbf2fe10711261150i5a69657aj3dba41b12a4b485b@mail.gmail.com> Date: Mon, 26 Nov 2007 20:50:22 +0100 From: "Attilio Rao" Sender: asmrookie@gmail.com To: "Jack F Vogel" In-Reply-To: <200711261947.lAQJl4HD033502@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200711261947.lAQJl4HD033502@repoman.freebsd.org> X-Google-Sender-Auth: a84071496c82e9ee Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2007 19:50:25 -0000 2007/11/26, Jack F Vogel : > jfv 2007-11-26 19:47:03 UTC > > FreeBSD src repository > > Modified files: > sys/dev/em if_em.c > Log: > Fix for a reported panic in certain circumstances. When > calling em_stop() now make sure the TX lock is held as > well as CORE. Thanks! To make it more explicit, callout_stop() needs to run always with referred lock held in order to not have a race for when running the callout handler. Now both callout_stop() are covert. Attilio -- Peace can only be achieved by understanding - A. Einstein