From owner-freebsd-arch@FreeBSD.ORG Thu Dec 18 12:53:24 2003 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 88D4116A4CE for ; Thu, 18 Dec 2003 12:53:24 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id BB04A43D1D for ; Thu, 18 Dec 2003 12:53:21 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 74408 invoked by uid 1000); 18 Dec 2003 20:53:22 -0000 Date: Thu, 18 Dec 2003 12:53:22 -0800 (PST) From: Nate Lawson To: arch@freebsd.org Message-ID: <20031218124754.O74387@root.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: acpi-jp@jp.freebsd.org Subject: acpi_toshiba and acpi_asus drivers X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Dec 2003 20:53:24 -0000 I'm prepping/reworking some user-submitted drivers for import. I'd like some comments on the directory structure. The hardware both drive is everything from fans to hotkeys to lcd backlight. Both are very hw-specific and do not conform to the ACPI spec although they do control their functions through ACPI. The directory structure I'm currently working with is: sys/i386/acpica/acpi_toshiba.c sys/i386/acpica/acpi_asus.c sys/modules/acpi_toshiba/Makefile sys/modules/acpi_asus/Makefile share/man/man4/acpi_toshiba.4 share/man/man4/acpi_asus.4 One alternative is to their modules under the acpi dir (e.g., sys/modules/acpi/acpi_toshiba). Also, the driver src could be sys/dev/acpi_toshiba. However, a new dir for just one file seems a bit much. My main concern is that as these drivers proliferate that we keep the dir structure neat. Thanks, Nate