From owner-freebsd-arch  Fri Mar 23 19:11:34 2001
Delivered-To: freebsd-arch@freebsd.org
Received: from filk.iinet.net.au (syncopation-dns.iinet.net.au [203.59.24.29])
	by hub.freebsd.org (Postfix) with SMTP id A977137B71B
	for <arch@FreeBSD.org>; Fri, 23 Mar 2001 19:11:29 -0800 (PST)
	(envelope-from julian@elischer.org)
Received: (qmail 6655 invoked by uid 666); 24 Mar 2001 03:13:05 -0000
Received: from i003-226.nv.iinet.net.au (HELO elischer.org) (203.59.3.226)
  by mail.m.iinet.net.au with SMTP; 24 Mar 2001 03:13:05 -0000
Message-ID: <3ABC105D.E01C0842@elischer.org>
Date: Fri, 23 Mar 2001 19:11:25 -0800
From: Julian Elischer <julian@elischer.org>
X-Mailer: Mozilla 4.7 [en] (X11; U; FreeBSD 5.0-CURRENT i386)
X-Accept-Language: en, hu
MIME-Version: 1.0
To: John Baldwin <jhb@FreeBSD.org>
Cc: Archie Cobbs <archie@dellroad.org>, arch@FreeBSD.org
Subject: Re: Critical Regions Round II
References: <XFMail.010323182612.jhb@FreeBSD.org>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-arch@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

John Baldwin wrote:
> Archie said:
> > Shouldn't these be, e.g.,
> >
> >   i386_disable_intr(), i386_enable_intr()
> >
> >     and
> >
> >   ia64_enable_intr(), ia64_disable_intr()
> >
> > That is, it seems like "machine dependent" has a strict meaning,
> > it means: specific to a single (one) architecture.
> 
> Sticking all MD stuff under a ${MACHINE_ARCH}_* namespace might be an
> interesting project in the future, but it wouldn't be a small undertaking.
> 
> > Or are we expecting to have code that looks like this:
> >
> >     #if defined(__i386__) || defined(__ia64__)
> >           disable_intr()
> >     #endif
> >
> > ??
> 
> No, this code should not be used outside of sys/${MACHINE_ARCH}, which is
> mostly how things were (aside from broken things like the joy driver) before
> SMPng.

I think the names should include either md_ or I386_ as a leadin so that people
who are 'copying' to make their own drivers a made fully aware
of what is going on.

-- 
      __--_|\  Julian Elischer
     /       \ julian@elischer.org
    (   OZ    ) World tour 2000-2001
---> X_.---._/  
            v

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message