From owner-svn-src-all@FreeBSD.ORG Mon Jun 8 02:32:11 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 20807D25; Mon, 8 Jun 2015 02:32:11 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-ob0-x230.google.com (mail-ob0-x230.google.com [IPv6:2607:f8b0:4003:c01::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D72B11FF1; Mon, 8 Jun 2015 02:32:10 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by obbqz1 with SMTP id qz1so70677641obb.3; Sun, 07 Jun 2015 19:32:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=iVYRK9LwUYb2TYC0qLirNsVeQ0/m4/MLFvQUuh6nbu4=; b=xx+sgnnC+DEtbd/wrt8B8sTAaeDWvRqib/ZY9KknHb6QGZg19Jtd5RXbNNaUKR8GaV PbH0HE+ZS6YPsd/j9thWjRXe7BpwXpfZSVjKCKuC1NF9AaHF6r7VflEoQo3Sv64+fgPg KPxKeiEEDZbKsNeKoykuqI19AZUP095yk3Mlhr1ekrFfrnj5mxx4zfn/vCRCSyZDFKag nraQGVWNZXveSj1XGBNNP3jen0f/3+sv/W5hYoGk9bIOVT9GPSNb4gc92ceS8x0hQOzK vZEtwmaFC48+iyscrqVWKAfyUzWlTiztqkxClwf31p8ugA16YlnJ6jePUUeMB2hWmjo5 h6KQ== MIME-Version: 1.0 X-Received: by 10.202.84.136 with SMTP id i130mr10982076oib.114.1433730730193; Sun, 07 Jun 2015 19:32:10 -0700 (PDT) Received: by 10.202.11.193 with HTTP; Sun, 7 Jun 2015 19:32:10 -0700 (PDT) Reply-To: araujo@FreeBSD.org In-Reply-To: <5574A2F9.8080404@FreeBSD.org> References: <201506071420.t57EKnio083109@svn.freebsd.org> <5F622B98-A1AE-41FB-8E4A-E767DB928689@gmail.com> <5574A2F9.8080404@FreeBSD.org> Date: Mon, 8 Jun 2015 10:32:10 +0800 Message-ID: Subject: Re: svn commit: r284116 - head/sys/boot/ficl From: Marcelo Araujo To: Pedro Giffuni Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jun 2015 02:32:11 -0000 2015-06-08 4:00 GMT+08:00 Pedro Giffuni : > > > On 06/07/15 12:06, Garrett Cooper wrote: > >> On Jun 7, 2015, at 07:20, Marcelo Araujo wrote: >>> >>> Author: araujo (ports committer) >>> Date: Sun Jun 7 14:20:48 2015 >>> New Revision: 284116 >>> URL: https://svnweb.freebsd.org/changeset/base/284116 >>> >>> Log: >>> Include header libi386.h to silence the clang warning of implicit >>> declaration >>> of functions biospci_*. >>> >>> Differential Revision: D2668 >>> Reviewed by: rodrigc >>> >>> Modified: >>> head/sys/boot/ficl/loader.c >>> >>> Modified: head/sys/boot/ficl/loader.c >>> >>> ============================================================================== >>> --- head/sys/boot/ficl/loader.c Sun Jun 7 13:59:02 2015 (r284115) >>> +++ head/sys/boot/ficl/loader.c Sun Jun 7 14:20:48 2015 (r284116) >>> @@ -46,6 +46,7 @@ >>> #include "bootstrap.h" >>> #include >>> #include "ficl.h" >>> +#include "../i386/libi386/libi386.h" >>> >> Hi Marcelo, >> >> This commit's explicitly polluting the ficl interpreter with code from >> x86 on all platforms. Seems like the code should be refactored to not >> explicitly include this symbol, then #include this header there. That's the >> real bug.. >> > +1 > > Let's revert and let the ficl GSoC take care of it. > > Pedro. > Done, thanks! -- -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)