From owner-svn-src-head@FreeBSD.ORG Sun Jun 14 18:53:06 2015 Return-Path: Delivered-To: svn-src-head@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4D026AF6; Sun, 14 Jun 2015 18:53:06 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-ig0-x232.google.com (mail-ig0-x232.google.com [IPv6:2607:f8b0:4001:c05::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 10676A94; Sun, 14 Jun 2015 18:53:06 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by igbos3 with SMTP id os3so4679613igb.0; Sun, 14 Jun 2015 11:53:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=Y2FOK1N6lU0wt2f56wgF6z8Qhz0tfrgUA0bQy+MJpbE=; b=NY6gLMogF8ExB0A+dv9dyiFOmgP4ceWPdsddZB4TtbBBpE7gCk25na0FhdI6UnMAxD CQl7HUlG4ja2VGGCCL66salb78PX5Wc+GHYEahmX7XrrlPGKTiREs0qAt1D6L3SvJWqq 1aGqGRTpNJH0EUWAnN0NnJvtMHMG5hP9NjhPaVBfCKO5AZ2uB2JUsva8GeoEMA+0ep3p Nr/Uw9Lz9JDCJfq9jyosed2H58LPlat65PECEHnhZ8wDvY2CIUJCwyX69JncY43nGFnG 1BLA3mxKytt43XUhNfCHZZ+/aWH+i1rj+CDI2IsInSdODvE7+m3HYw4GWNLEYqwF/jtY Gzbw== MIME-Version: 1.0 X-Received: by 10.42.176.8 with SMTP id bc8mr10965659icb.22.1434307985494; Sun, 14 Jun 2015 11:53:05 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.36.38.133 with HTTP; Sun, 14 Jun 2015 11:53:05 -0700 (PDT) In-Reply-To: <557DCBED.2010804@fastmail.net> References: <201506100127.t5A1RdX6051959@svn.freebsd.org> <20150612204309.11dd3391@kan> <20150613024916.GA98218@troutmask.apl.washington.edu> <1434208622.1415.57.camel@freebsd.org> <557C661F.8080104@freebsd.org> <860017ED-D754-450C-865D-2D81A30C2212@xcllnt.net> <20150614100045.GF58397@zxy.spb.ru> <557D55CB.5050009@fastmail.net> <20150614171031.GA5857@troutmask.apl.washington.edu> <557DCBED.2010804@fastmail.net> Date: Sun, 14 Jun 2015 11:53:05 -0700 X-Google-Sender-Auth: LAtV2_yQWPrNb7XoQsppE3dFbUg Message-ID: Subject: Re: svn commit: r284198 - head/bin/ls From: Adrian Chadd To: Bruce Simpson Cc: Steve Kargl , Slawa Olhovchenkov , Craig Rodrigues , Marcel Moolenaar , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , Marcel Moolenaar , "src-committers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jun 2015 18:53:06 -0000 We have busybox already - it's called bsdbox, and it's in base, and we're already using it, and yes, it does pull in libxo. :) I'm not worried about the size increase of libxo. That's the wrong thing to focus on. If it gets much more bloated then I'll poke people with the big "what are you thinking" stick. The issues people have aren't size related, they're "this API needs improvement and we have bugs introduced into tools." I do like how zero percent of the comments are "hey, maybe we need unit tests that run these tools and ensure they output the right stuff." If this were ${WORK} and I were ${BOSS}, I'd have asked the libxo developers to include unit tests before/after for each thing they broke, so we don't have a repeat of this kind of thing. But, this apparently isn't ${WORK} and I definitely don't want to be anyones boss, so.. -a