From owner-svn-ports-all@FreeBSD.ORG Tue Oct 22 15:58:58 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 7411465E; Tue, 22 Oct 2013 15:58:58 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 328B82453; Tue, 22 Oct 2013 15:58:58 +0000 (UTC) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id AC5B6BDC1F; Tue, 22 Oct 2013 17:58:55 +0200 (CEST) Received: from gw.in.absolight.net (gw-ecl.in.absolight.net [79.143.241.69]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "gw.in.absolight.net", Issuer "CA Cert Signing Authority" (not verified)) by prod2.absolight.net (Postfix) with ESMTPSA id 72667BDC1D; Tue, 22 Oct 2013 17:58:55 +0200 (CEST) Received: from ogg.in.absolight.net (ogg.in.absolight.net [79.143.241.239]) by gw.in.absolight.net (Postfix) with ESMTP id 8C3B26113; Tue, 22 Oct 2013 17:58:54 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by ogg.in.absolight.net (Postfix) with ESMTP id 1A0FC6217BD1; Tue, 22 Oct 2013 17:58:53 +0200 (CEST) Date: Tue, 22 Oct 2013 17:58:53 +0200 From: Mathieu Arnold To: Alexey Dokuchaev , Bryan Drewery Subject: Re: svn commit: r331243 - head/sysutils/tmux Message-ID: In-Reply-To: <20131022155520.GA79375@FreeBSD.org> References: <201310220906.r9M96xBM055204@svn.freebsd.org> <526653CB.3080106@FreeBSD.org> <20131022155520.GA79375@FreeBSD.org> X-Mailer: Mulberry/4.0.8 (Mac OS X) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline Cc: Mathieu Arnold , svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Oct 2013 15:58:58 -0000 +--On 22 octobre 2013 15:55:20 +0000 Alexey Dokuchaev wrote: | On Tue, Oct 22, 2013 at 05:30:35AM -0500, Bryan Drewery wrote: |> On 10/22/2013 4:06 AM, Mathieu Arnold wrote: |> > .if ${PORT_OPTIONS:MEXAMPLES} |> > - @${MKDIR} ${EXAMPLESDIR} |> > - @${INSTALL_DATA} ${WRKSRC}/examples/* ${EXAMPLESDIR} |> > + @${MKDIR} ${STAGEDIR}${EXAMPLESDIR} |> > + @${INSTALL_DATA} ${WRKSRC}/examples/* ${STAGEDIR}${EXAMPLESDIR} |> > .endif |> |> I think the general trend is to not hide any install commands since it |> is touching the user's system, and is good for debugging build logs. | | (Not just to Mathieu, writing this given another occasion.) | | Yes, please, make installation commands vocal (muting mkdir's is optional, | some people like it, it's okay). I'll do that in the future :-) | I would also like to mention that, unless DOCS/EXAMPLES require extra | dependencies (e.g. Doxygen/DocBook) or just huge enough to create insane | I/O load, for staged ports, you can remove those .if ${PORT_OPTIONS...} | checks. In many cases, it would collaterally allow to remove .include | (when there are no other PORT_OPTIONS checks). Well, I usually do that, but for other people's ports, when my main goal was to convert to staging, I didn't want to touch too many other things :-) -- Mathieu Arnold