From owner-svn-src-all@freebsd.org Fri Feb 16 16:44:49 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8B403F23DC7; Fri, 16 Feb 2018 16:44:49 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-it0-x22d.google.com (mail-it0-x22d.google.com [IPv6:2607:f8b0:4001:c0b::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1FA1084E8F; Fri, 16 Feb 2018 16:44:49 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-it0-x22d.google.com with SMTP id d10so2528670itj.2; Fri, 16 Feb 2018 08:44:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=21b71FkJSNeKb2i/Hxhab5fUhTZTMTBoXfxqlN/A3NI=; b=NoGxtFjfEMVq7Yp0c9IZMKI0HIyR1QoMM8EUDylU6cFESeSsWw53H/a/cyI4wrjHHq 9ZACtOCQNtR6I9Puz738WnUF+nMqprETJHvWyz1AWbuivlzC6CSGPkDaL7XCwhPvdNwz cxGgeP2IX/kpKQbtWT0X+7kG5Vi7kwt3wTLBsXOOWfKQr3CXEkEQFoWrPWAUN6wH3XaN PJ82CQ/6ROui2f6IY77UXOSeVBymM067dCsKwu43NRiDChA+k5wk02ij72/drw1d4BVc y+bP9azlXLwmw/RW2nDJYCefo6I94hVhtaq7vqb9Q/Qlvt16WCZBpWSuh87EW5rBD1FA qKTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=21b71FkJSNeKb2i/Hxhab5fUhTZTMTBoXfxqlN/A3NI=; b=q/mqbGuaqGp3gbDak3GrWCcYt727ZBcHhrpNHQlgJj1cWnLeQ8/JQQMQIKHU/f+pqW 1AwRSczzCO9n+ywOb4/nmjyreGLuYOqvc1Oj+LvWM5qbODVROeKC6vVpcloFQOc3CDFv chMsgKQfcuOxa3tVDB66hb4rLlVNGZO9pjzb71kn9w51nk8Tvro/ZtbBdd8t5sqfV+xl N40oHdzG/rSqiybkUAA8+p8nnokiB97Xoj+IaBnsnQYjSGMZIRhiBYOtP/0daULTP91f JjRhtXZY16pJK9iwCiQKL4+8NyCqch9sQHNdmlKFwl2fBFww/FlrA31b0cL/PbH+260t Lq3A== X-Gm-Message-State: APf1xPDx3Rqzj787caeWGzuy+tBhncU47hR0ors8kBwcF47/6FGNku0g MeZS1/GvHfLtZUu4/5s/fZDUvQ== X-Google-Smtp-Source: AH8x224ioOmoaEEn3oBKcTEHi1JnfJCoX+WHeYMLDMUVcB8AwCWVPAIbIQreSDj6s9FbelD1EG0iPg== X-Received: by 10.36.198.194 with SMTP id j185mr8933472itg.140.1518799488176; Fri, 16 Feb 2018 08:44:48 -0800 (PST) Received: from raichu (toroon0560w-lp130-01-174-88-76-226.dsl.bell.ca. [174.88.76.226]) by smtp.gmail.com with ESMTPSA id k204sm17617378iok.68.2018.02.16.08.44.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Feb 2018 08:44:47 -0800 (PST) Sender: Mark Johnston Date: Fri, 16 Feb 2018 11:44:45 -0500 From: Mark Johnston To: Benno Rice Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r329269 - head/stand/i386/boot2 Message-ID: <20180216164445.GB55620@raichu> References: <201802141807.w1EI7Ror036078@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201802141807.w1EI7Ror036078@repo.freebsd.org> User-Agent: Mutt/1.9.3 (2018-01-21) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Feb 2018 16:44:49 -0000 On Wed, Feb 14, 2018 at 06:07:27PM +0000, Benno Rice wrote: > Author: benno > Date: Wed Feb 14 18:07:27 2018 > New Revision: 329269 > URL: https://svnweb.freebsd.org/changeset/base/329269 > > Log: > Reformat to come significantly closer to style(9). > > Reviewed by: imp, jhibbits > Differential Revision: https://reviews.freebsd.org/D14366 > > Modified: > head/stand/i386/boot2/boot2.c > > Modified: head/stand/i386/boot2/boot2.c > ============================================================================== > --- head/stand/i386/boot2/boot2.c Wed Feb 14 18:05:37 2018 (r329268) > +++ head/stand/i386/boot2/boot2.c Wed Feb 14 18:07:27 2018 (r329269) > [...] > #if SERIAL > - } else if (c == 'S') { > - j = 0; > - while ((unsigned int)(i = *arg++ - '0') <= 9) > - j = j * 10 + i; > - if (j > 0 && i == -'0') { > - comspeed = j; > - break; > - } > - /* Fall through to error below ('S' not in optstr[]). */ > + } else if (c == 'S') { > + j = 0; > + while (*arg <= '9') { > + i = (unsigned int)(*arg - '0'); > + j = j * 10 + i; > + arg++; > + } > + if (j > 0 && i == -'0') { > + comspeed = j; > + break; > + } The gcc build is failing now with a claim that "i" may be used uninitialized in the if-statement above. It looks like a bogus error though.