Date: Tue, 25 Sep 2012 02:55:21 +0100 From: "Steven Hartland" <killing@multiplay.co.uk> To: "Ryan Stone" <rysto32@gmail.com> Cc: freebsd-fs@freebsd.org, freebsd-current@freebsd.org Subject: Re: ZFS TRIM support committed to HEAD. Message-ID: <BC50509A1886420890AB3FD6419B530B@multiplay.co.uk> References: <20120923195357.GO1454@garage.freebsd.pl><1735E492-3C3C-491A-82E2-884E976B4BC4@gid.co.uk><20120923222520.GS1454@garage.freebsd.pl><D637D49E-27B3-4169-BC27-D5A7409040B9@gid.co.uk><20CC6F2BF08D47ED802318697542A15D@multiplay.co.uk><20120924161654.GA1413@garage.freebsd.pl><AE489E37693F45B887BDFB230EFBB46B@multiplay.co.uk> <CAFMmRNxGc8HOsEP6vtmr_90Cczh9PeWn31dSZYKX6opE=_m_sw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
----- Original Message -----
From: "Ryan Stone"
>> Ahh yes looks like ATA supports BIO_DELETE via ATA_CFA_ERASE if the drive
>> announces ATA_PROTO_CFA, so I can only assume this is failing when it
>> shouldn't.
>>
>> Might be nice to investigate what's happening and fix, but as ATA is
>> being replaced by CAM ATA not sure its worth it?
>
> I believe that the code that you are looking at refers to a old
> command that is only implemented by CompactFlash cards. The ad(4)
> driver does not currently support the TRIM command. I have an
> internal patch that implements it for FreeBSD 8.2; if there's interest
> I could try to dig it out.
It may well be but that's the only code in ad driver that I can see
which sets DISKFLAG_CAN_DELETE and without that geom_disk should
trigger EOPNOTSUPP and hence go into the unsupported not the fail
case.
Regards
Steve
================================================
This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it.
In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337
or return the E.mail to postmaster@multiplay.co.uk.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BC50509A1886420890AB3FD6419B530B>