From owner-freebsd-arch@FreeBSD.ORG Wed Jan 5 10:18:24 2011 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CE4E3106566C for ; Wed, 5 Jan 2011 10:18:24 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 4F9488FC0C for ; Wed, 5 Jan 2011 10:18:24 +0000 (UTC) Received: from outgoing.leidinger.net (p57B3A1FD.dip.t-dialin.net [87.179.161.253]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id F113E844012; Wed, 5 Jan 2011 11:18:19 +0100 (CET) Received: from webmail.leidinger.net (unknown [IPv6:fd73:10c7:2053:1::2:102]) by outgoing.leidinger.net (Postfix) with ESMTP id 829E41993; Wed, 5 Jan 2011 11:18:13 +0100 (CET) Received: (from www@localhost) by webmail.leidinger.net (8.14.4/8.13.8/Submit) id p05AHvwA099090; Wed, 5 Jan 2011 11:17:57 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: from pslux.ec.europa.eu (pslux.ec.europa.eu [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Wed, 05 Jan 2011 11:17:57 +0100 Message-ID: <20110105111757.71361dh7p5bqyhy8@webmail.leidinger.net> Date: Wed, 05 Jan 2011 11:17:57 +0100 From: Alexander Leidinger To: David Xu References: <20110103220153.69cf59e0@kan.dnsalias.net> <20110104082252.45bb5e7f@kan.dnsalias.net> <4D23A2CF.1010904@freebsd.org> <20110105100452.16086vb1bb08xcco@webmail.leidinger.net> <4D244042.4010004@freebsd.org> In-Reply-To: <4D244042.4010004@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.4) X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: F113E844012.A5B97 X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=1.274, required 6, autolearn=disabled, RDNS_NONE 1.27) X-EBL-MailScanner-SpamScore: s X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1294827500.70349@PP4FyZT/nQl8dVsrr4WvpQ X-EBL-Spam-Status: No Cc: arch@freebsd.org Subject: Re: Linux kernel compatability X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jan 2011 10:18:25 -0000 Quoting David Xu (from Wed, 05 Jan 2011 17:56:18 +0800): > Alexander Leidinger wrote: >> Quoting Jeff Roberson (from Tue, 4 Jan >> 2011 13:13:00 -1000 (HST)): >> >>> After this discussion I'm leaning towards leaving the layer I have >>> in the ofed/ directory and leaving it tied to the version of ofed >>> we currently have imported. >> >> To give you one more little argument in favour of this: copies in >> SVN are cheap. If there is the need to have the compat shim >> available for something else, it can be put into another place later. >> >> On a somewhat related area: now that you've done this huge compat >> work you have a very good idea which parts correspond to what in >> the other OS. It would be great if this could be documented >> somewhere (wiki?) in a way that people which are interested to >> write a FreeBSD native driver just need to have a look at some >> pages to be able to see what linux stuff they have to change in >> which way to get a big part of the porting covered. IMO this would >> also help in reviewing and verifying the correctness of your >> current work (and as such would be beneficial to the sponsors of >> this work), as people could see if you missed some semantic >> differences or overlooked some implicit assumptions. > This is still uncertain, the patch is so large, I don't know who will > review it, the person who has ability to review it must know Linux > locking and OFED very well ? plus few of us are using OFED. I do not think that people do need to know both at the same. I think the most critical part in the review is the linux compat shim. The pure OFED part is shared with Linux. Currently one needs to know both worlds (Linux + FreeBSD) to review it. If there is some good documentation, this can be split up into two parts. One part for people with good linux knowledge to check if the description in the docs is OK (semantic, invariants, assumptions, ...) and one part for people with good FreeBSD knowledge to check if the FreeBSD part is implementing what is described. Bye, Alexander. -- One can't proceed from the informal to the formal by formal means. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137