Date: Thu, 7 Nov 2019 22:04:15 +0000 From: Colin Percival <cperciva@tarsnap.com> To: Andriy Gapon <avg@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r354482 - head/sys/x86/x86 Message-ID: <0100016e47e58993-b0cc9187-5881-43ba-a775-4fc96dca975a-000000@email.amazonses.com> In-Reply-To: <69cbaec6-5799-9640-89bd-bdb5b6ae9843@FreeBSD.org> References: <201911072114.xA7LExVP090362@repo.freebsd.org> <0100016e47bc3e05-560c061d-ef2e-41b1-9166-20d80cb6b81d-000000@email.amazonses.com> <69cbaec6-5799-9640-89bd-bdb5b6ae9843@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2019-11-07 13:34, Andriy Gapon wrote: > On 07/11/2019 23:19, Colin Percival wrote: >> On 2019-11-07 13:14, Andriy Gapon wrote: >>> x86 stack_save_td_running() can work safely only if IPI_TRACE is a >>> non-maskable interrupt. But at the moment FreeBSD/Xen does not provide >>> support for the NMI delivery mode. So, mark the functionality as >>> unsupported similarly to other platforms without NMI. >>> [...] >>> +#ifdef XENHVM >> >> I'm not sure this does what you intended. XENHVM simply adds *support* for >> running under Xen/HVM, and it's part of the GENERIC kernel. > > Oh... I should not have rushed. > So, I should really check for a run-time Xen marker? I'm guessing that you want #include <sys/systm.h> ... if (vm_guest == VM_GUEST_XEN) return (EOPNOTSUPP); -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0100016e47e58993-b0cc9187-5881-43ba-a775-4fc96dca975a-000000>