From owner-dev-commits-ports-main@freebsd.org Thu Apr 22 11:00:21 2021 Return-Path: Delivered-To: dev-commits-ports-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 714E25EB574; Thu, 22 Apr 2021 11:00:21 +0000 (UTC) (envelope-from grembo@freebsd.org) Received: from mail.evolve.de (mail.evolve.de [213.239.217.29]) (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail.evolve.de", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FQvb855lQz3k0N; Thu, 22 Apr 2021 11:00:20 +0000 (UTC) (envelope-from grembo@freebsd.org) Received: by mail.evolve.de (OpenSMTPD) with ESMTP id 17003b77; Thu, 22 Apr 2021 11:00:18 +0000 (UTC) Received: by mail.evolve.de (OpenSMTPD) with ESMTPSA id df5149df (TLSv1.3:AEAD-CHACHA20-POLY1305-SHA256:256:NO); Thu, 22 Apr 2021 11:00:17 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (1.0) Subject: Re: git: 5b7c17856512 - main - git hooks: Rework authorship instructions. From: Michael Gmelin In-Reply-To: <20210422104914.d3kwtrwl2jovwvu2@aching.in.mat.cc> Date: Thu, 22 Apr 2021 13:00:16 +0200 Cc: Alexey Dokuchaev , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Message-Id: References: <20210422104914.d3kwtrwl2jovwvu2@aching.in.mat.cc> To: Mathieu Arnold X-Mailer: iPhone Mail (18D70) X-Rspamd-Queue-Id: 4FQvb855lQz3k0N X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-ports-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the main branch of the FreeBSD ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Apr 2021 11:00:21 -0000 > On 22. Apr 2021, at 12:49, Mathieu Arnold wrote: >=20 > =EF=BB=BFOn Thu, Apr 22, 2021 at 10:43:46AM +0000, Alexey Dokuchaev wrote:= >>> On Thu, Apr 22, 2021 at 12:16:16PM +0200, Mathieu Arnold wrote: >>> On Thu, Apr 22, 2021 at 12:10:26PM +0200, Michael Gmelin wrote: >>>> ... >>>> I agree that author should only be used if a submission is applied >>>> unaltered (pull request/git patch). >>>=20 >>> Submitted by has always been for submission that was unaltered (or only >>> slightly altered) if it was only the basis of the work, then "submitted >>> by" is not to be used, in those cases, reported by is the correct >>> choice. >>=20 >> Not really, no. "PR:/Submitted by:" is canonical combination, yet most >> of us modify submitted patches because they almost always need more work.= >=20 > Then you are misusing Submitted by. Submitted by was supposed to be > used when you committed something that was, well, submitted by someone > else. If the work is yours, and that you based your work on someone > else's, then, it is not submitted by them. >=20 I don=E2=80=99t think git author should be used if anything is altered, incl= uding the commit message (as a contributor, I wouldn=E2=80=99t want to give a= nyone the impression that the rude ramblings of a grumpy committer are to be= attributed to me). That doesn=E2=80=99t map well to our model though. I ass= ume the git working group discussed this in detail, especially when it comes= to accepting pull requests over various channels. -m > --=20 > Mathieu Arnold