From owner-svn-ports-all@FreeBSD.ORG  Sat Aug 25 17:31:07 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CF437106566B;
	Sat, 25 Aug 2012 17:31:07 +0000 (UTC)
	(envelope-from ohauer@FreeBSD.org)
Received: from p578be941.dip0.t-ipconnect.de (p578be941.dip0.t-ipconnect.de
	[87.139.233.65])
	by mx1.freebsd.org (Postfix) with ESMTP id 823358FC18;
	Sat, 25 Aug 2012 17:31:07 +0000 (UTC)
Received: from [192.168.0.100] (cde1100.uni.vrs [192.168.0.100])
	(Authenticated sender: ohauer)
	by p578be941.dip0.t-ipconnect.de (Postfix) with ESMTPSA id 850D8208BB; 
	Sat, 25 Aug 2012 19:31:04 +0200 (CEST)
Message-ID: <50390BDE.20606@FreeBSD.org>
Date: Sat, 25 Aug 2012 19:31:10 +0200
From: Olli Hauer <ohauer@FreeBSD.org>
User-Agent: Mozilla/5.0 (Windows NT 5.1;
	rv:14.0) Gecko/20120713 Thunderbird/14.0
MIME-Version: 1.0
To: Alexey Dokuchaev <danfe@FreeBSD.org>
References: <201208251648.q7PGmtS6066622@svn.freebsd.org>
	<20120825170211.GA34647@FreeBSD.org>
In-Reply-To: <20120825170211.GA34647@FreeBSD.org>
X-Enigmail-Version: 1.4.3
Content-Type: text/plain; charset=KOI8-R
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
	ports-committers@freebsd.org
Subject: Re: svn commit: r303150 - head/www/mod_auth_cas
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: svn-ports-all@freebsd.org
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
	<mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
	<mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 25 Aug 2012 17:31:07 -0000

On 2012-08-25 19:02, Alexey Dokuchaev wrote:
> On Sat, Aug 25, 2012 at 04:48:55PM +0000, Olli Hauer wrote:
>> New Revision: 303150
>> URL: http://svn.freebsd.org/changeset/ports/303150
>>
>> +post-install:
>> +	@${CAT} ${PKGMESSAGE}
>> +
> 
> cat(1)ing ${PKGMESSAGE} in post-install could benefit from being surrounded
> by ${ECHO_MSG}'s on both sides.  This makes installation from port and package
> behave similarly.
> 

I agree, thats why I always add a line with ========... at the top and at the bottom and have at last one whitespace before the text.
Instead two times ${ECHO_MSG} I would prefer an additional empty line at the top/bottom in pkg-message.

display installed from port:
[preparing module `auth_cas' in /usr/local/etc/apache22/httpd.conf]
======================================================================
 Set a few required parameters in your Apache configuration:

display installed from package (pkg):
Installing ap22-mod_auth_cas-1.0.9.1...[preparing module `auth_cas' in /usr/local/etc/apache22/httpd.conf]
 done
======================================================================
 Set a few required parameters in your Apache configuration:

--
Regards,
olli