From owner-cvs-all@FreeBSD.ORG Sat Aug 12 22:04:48 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4FA1C16A4DA; Sat, 12 Aug 2006 22:04:48 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from server.t-hosting.hu (server.t-hosting.hu [217.20.133.7]) by mx1.FreeBSD.org (Postfix) with ESMTP id C2F0D43D45; Sat, 12 Aug 2006 22:04:47 +0000 (GMT) (envelope-from gabor@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) by server.t-hosting.hu (Postfix) with ESMTP id BDC5F99B8C7; Sun, 13 Aug 2006 00:04:46 +0200 (CEST) X-Virus-Scanned: amavisd-new at t-hosting.hu Received: from server.t-hosting.hu ([127.0.0.1]) by localhost (server.t-hosting.hu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id hL5nAV7b6B8w; Sun, 13 Aug 2006 00:04:43 +0200 (CEST) Received: from [192.168.2.186] (catv-50635cb6.catv.broadband.hu [80.99.92.182]) by server.t-hosting.hu (Postfix) with ESMTP id DCA4499B8BA; Sun, 13 Aug 2006 00:04:42 +0200 (CEST) Message-ID: <44DE5079.8010807@FreeBSD.org> Date: Sun, 13 Aug 2006 00:04:41 +0200 From: =?ISO-8859-2?Q?G=E1bor_K=F6vesd=E1n?= User-Agent: Thunderbird 1.5.0.5 (Windows/20060719) MIME-Version: 1.0 To: pav@FreeBSD.org References: <200608122126.k7CLQ7qN091943@repoman.freebsd.org> <44DE4C6F.4040707@FreeBSD.org> <1155419695.12089.0.camel@ikaros.oook.cz> In-Reply-To: <1155419695.12089.0.camel@ikaros.oook.cz> Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: 8bit Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/security/lsh Makefile ports/security/lsh/files patch-nettle-openssl.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Aug 2006 22:04:48 -0000 Pav Lucistnik wrote: > Gábor Kövesdán píše v so 12. 08. 2006 v 23:47 +0200: > >> Pav Lucistnik wrote: >> >>> pav 2006-08-12 21:26:07 UTC >>> >>> FreeBSD ports repository >>> >>> Modified files: >>> security/lsh Makefile >>> Added files: >>> security/lsh/files patch-nettle-openssl.c >>> Log: >>> - Fix build on 4.X >>> - Respect CC and CFLAGS >>> >>> PR: ports/101750 >>> Submitted by: Babak Farrokhi (maintainer) >>> >>> Revision Changes Path >>> 1.35 +2 -0 ports/security/lsh/Makefile >>> 1.1 +10 -0 ports/security/lsh/files/patch-nettle-openssl.c (new) >>> > > >> I think it also needs a PORTREVISION bump if you make a port respect CC >> since such change affects the build phase of the port. >> > > Imagine you are user with already installed lsh; do you want to > recompile just because of this change? > Yes, because I like optimized binaries. :) > Imagine you are user who downloads the package from the ftp site. > Do you mind you don't have this change? > > No, of course not, but there are other cases when a user might not want to do so, but they are require a PORTREVISION bump, e.g. adding something specific thing to OPTIONS. If the give user doesn't use the new functionality, (s)he will get the same, but portupgrade will notice the bump at all. -- Cheers, Gabor