From owner-freebsd-net@FreeBSD.ORG  Sat Dec  5 20:30:04 2009
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 26934106568F
	for <freebsd-net@hub.freebsd.org>; Sat,  5 Dec 2009 20:30:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 153818FC14
	for <freebsd-net@hub.freebsd.org>; Sat,  5 Dec 2009 20:30:04 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id nB5KU3WN087308
	for <freebsd-net@freefall.freebsd.org>; Sat, 5 Dec 2009 20:30:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id nB5KU3D9087301;
	Sat, 5 Dec 2009 20:30:03 GMT (envelope-from gnats)
Date: Sat, 5 Dec 2009 20:30:03 GMT
Message-Id: <200912052030.nB5KU3D9087301@freefall.freebsd.org>
To: freebsd-net@FreeBSD.org
From: Benjamin Kaduk <kaduk@MIT.EDU>
Cc: 
Subject: Re: kern/140036: [iwn] [lor] lock order reversal with iwn0_com_lock
 and iwn0 softc lock
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Benjamin Kaduk <kaduk@MIT.EDU>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Dec 2009 20:30:04 -0000

The following reply was made to PR kern/140036; it has been noted by GNATS.

From: Benjamin Kaduk <kaduk@MIT.EDU>
To: Bernhard Schmidt <bschmidt@techwires.net>
Cc: sam@freebsd.org, bug-followup@freebsd.org
Subject: Re: kern/140036: [iwn] [lor] lock order reversal with iwn0_com_lock
 and iwn0 softc lock
Date: Sat, 5 Dec 2009 15:25:25 -0500 (EST)

 On Sat, 5 Dec 2009, Bernhard Schmidt wrote:
 
 > On Saturday 05 December 2009 03:49:42 Benjamin Kaduk wrote:
 >> Okay, I've been getting these lockups fairly frequently -- in fact,
 >> there was this one room where I was getting them every five minutes
 >> or so.  I hypothesized that dissociation/association events might
 >> be triggers, so I set dev.iwn.0.debug=-1 and started wandering around
 >> this building (which is chock full of APs).
 >> I get:
 >> panic: lock (sleep mutex) iwn0_com_lock not locked @
 >> /usr/devel/iwn/freebsd/sys/modules/iwn/../../dev/iwn/if_iwn.c:3254
 >
 > Are you sure your code is in sync? there is nothing accessing the lock in
 > if_iwn.c:3254
 >
 > 3251	if ((ifp->if_drv_flags & IFF_DRV_RUNNING) == 0) {
 > 3252		ieee80211_free_node(ni);
 > 3253		m_freem(m);
 > 3254		return ENETDOWN;
 > 3255	}
 >
 
 Apparently not -- `svn info` claims that I only have r13, and
 the web the web interface shows up to r20.
 I guess I've been using cvs for too long, and expected
 `${VCS_COMMAND} diff` to default to showing differences from the
 head of the repository/current branch.
 
 I'll update and revert my change to net80211/ieee80211_proto.c and
 see what changes.
 
 Sorry for the noise,
 
 Ben