From owner-svn-ports-head@freebsd.org  Thu Dec  6 12:12:14 2018
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id AFC9E132AA70;
 Thu,  6 Dec 2018 12:12:14 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 52A0D8EE3C;
 Thu,  6 Dec 2018 12:12:14 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 268D78C32; Thu,  6 Dec 2018 12:12:14 +0000 (UTC)
Date: Thu, 6 Dec 2018 12:12:14 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Joseph Mingrone <jrm@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r486753 - head/cad/gmsh
Message-ID: <20181206121214.GA23700@FreeBSD.org>
References: <201812061155.wB6Bt0hZ079960@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201812061155.wB6Bt0hZ079960@repo.freebsd.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Rspamd-Queue-Id: 52A0D8EE3C
X-Spamd-Result: default: False [-0.45 / 15.00];
 local_wl_from(0.00)[freebsd.org];
 NEURAL_HAM_MEDIUM(-0.11)[-0.105,0];
 NEURAL_SPAM_LONG(0.42)[0.424,0];
 ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US];
 NEURAL_HAM_SHORT(-0.76)[-0.765,0]
X-Rspamd-Server: mx1.freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Dec 2018 12:12:14 -0000

On Thu, Dec 06, 2018 at 11:55:00AM +0000, Joseph Mingrone wrote:
> New Revision: 486753
> URL: https://svnweb.freebsd.org/changeset/ports/486753
> 
> Log:
>   cad/gmsh: Update to 4.0.6
>   
>   Upstream change log:
>   https://gitlab.onelab.info/gmsh/gmsh/blob/master/CHANGELOG.txt
> 
> -BROKEN_FreeBSD_12_i386=	fails to build on FreeBSD 12 i386 due to a clang bug: https://llvm.org/bugs/show_bug.cgi?id=21903
> -BROKEN_FreeBSD_13_i386=	fails to build on FreeBSD 13 i386 due to a clang bug: https://llvm.org/bugs/show_bug.cgi?id=21903

It would be nice to explicitly acknowledge in the commit log that it builds
fine on i386 now, and these lines were not removed by accident.

> -MAKE_JOBS_UNSAFE=	yes
> -

I didn't find anything about parallel build fixes in the changelog, and
commit message does not mention it as well.  It is expected that when -jX
unsafe issue it fixed (and thus MAKE_JOBS_UNSAFE removed), an approximate
explanation is provided in the commit log.  People often try parallel
builds locally and they seem fine, while the problem might just not so
easily manifest itself.

./danfe