Date: Thu, 29 Apr 2010 17:19:41 -0400 From: Ryan Stone <rysto32@gmail.com> To: =?ISO-8859-2?Q?Luk=E1=B9_Czerner?= <czerner.lukas@gmail.com> Cc: freebsd-hackers@freebsd.org Subject: Re: ioctl, copy string from user Message-ID: <x2sbc2d971004291419o546d8895vd4fcab2ee15f37b9@mail.gmail.com> In-Reply-To: <alpine.DEB.1.10.1004292256580.30007@a04-0215a.kn.vutbr.cz> References: <alpine.DEB.1.10.1004291938210.30007@a04-0215a.kn.vutbr.cz> <201004291418.09768.jhb@freebsd.org> <alpine.DEB.1.10.1004292114360.30007@a04-0215a.kn.vutbr.cz> <201004291606.35899.jhb@freebsd.org> <alpine.DEB.1.10.1004292220170.30007@a04-0215a.kn.vutbr.cz> <alpine.DEB.1.10.1004292256580.30007@a04-0215a.kn.vutbr.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
> Apparently I need to tell ioctl how big is the variable I am
> providing to it ([MAXLEN]). The odd thing is, when I have a structure
> like this:
>
> struct lrfs_attach_info {
> =A0 =A0 =A0 =A0char *name;
> =A0 =A0 =A0 =A0int priority;
> };
>
> and I pass the pointer to that structure to the ioctl, it just
> works. I can even use the 'name' string from the structure without
> any problems, apparently it translates the pointer properly, but I
> did not expect this...
I think that you'll find that what actually happens is that you're
reading from the userspace pointer. That will work as long as the
pointer is mapped, but you'll panic if what it points to gets swapped
out or is invalid.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?x2sbc2d971004291419o546d8895vd4fcab2ee15f37b9>