From owner-cvs-all  Thu Mar  6 23:19:40 2003
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A474F37B401; Thu,  6 Mar 2003 23:19:38 -0800 (PST)
Received: from smtp01.syd.iprimus.net.au (smtp01.syd.iprimus.net.au [210.50.30.70])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 1B00B43F3F; Thu,  6 Mar 2003 23:19:37 -0800 (PST)
	(envelope-from tim@robbins.dropbear.id.au)
Received: from dilbert.robbins.dropbear.id.au ([203.134.131.150]) by smtp01.syd.iprimus.net.au with Microsoft SMTPSVC(5.0.2195.5600);
	 Fri, 7 Mar 2003 18:19:33 +1100
Received: from dilbert.robbins.dropbear.id.au (xtt4bl02mlztefc3@localhost [127.0.0.1])
	by dilbert.robbins.dropbear.id.au (8.12.6/8.12.6) with ESMTP id h277JXJK021772;
	Fri, 7 Mar 2003 18:19:33 +1100 (EST)
	(envelope-from tim@dilbert.robbins.dropbear.id.au)
Received: (from tim@localhost)
	by dilbert.robbins.dropbear.id.au (8.12.6/8.12.6/Submit) id h277JXqZ021771;
	Fri, 7 Mar 2003 18:19:33 +1100 (EST)
	(envelope-from tim)
Date: Fri, 7 Mar 2003 18:19:33 +1100
From: Tim Robbins <tjr@FreeBSD.org>
To: Jeff Roberson <jroberson@chesapeake.net>
Cc: Robert Watson <rwatson@FreeBSD.org>, src-committers@FreeBSD.org,
	cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/coda coda_vnops.c
Message-ID: <20030307181933.C19473@dilbert.robbins.dropbear.id.au>
References: <Pine.NEB.3.96L.1030305112755.56689A-100000@fledge.watson.org> <20030307013326.W47958-100000@mail.chesapeake.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <20030307013326.W47958-100000@mail.chesapeake.net>; from jroberson@chesapeake.net on Fri, Mar 07, 2003 at 01:33:52AM -0500
X-OriginalArrivalTime: 07 Mar 2003 07:19:34.0325 (UTC) FILETIME=[E7579E50:01C2E479]
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Fri, Mar 07, 2003 at 01:33:52AM -0500, Jeff Roberson wrote:

> On Wed, 5 Mar 2003, Robert Watson wrote:
> 
> >
> > > tjr         2003/03/05 01:52:04 PST
> > >   Log:
> > >   Handle the case where a_uio->uio_td == NULL properly in coda_readlink().
> > >   This happens when called from lookup().
> >
> > Hmm.  An interesting question is whether this should actually be allowed
> > to happen.
> 
> Yeah, thats what I thought when I saw this too.  Any thoughts on this tjr?

I don't see why it can't use the thread from the struct componentname.
BTW, the call to VOP_READLINK with uio_td == NULL is in namei(), not
lookup(), the commit message was wrong.


Tim

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message