From owner-freebsd-hackers  Tue Nov 12 13:21:03 1996
Return-Path: owner-hackers
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id NAA27854
          for hackers-outgoing; Tue, 12 Nov 1996 13:21:03 -0800 (PST)
Received: from pluto.plutotech.com (root@pluto.plutotech.com [206.168.67.1])
          by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id NAA27849
          for <freebsd-hackers@freebsd.org>; Tue, 12 Nov 1996 13:20:59 -0800 (PST)
Received: from shane.plutotech.com (durian@shane.plutotech.com [206.168.67.149]) by pluto.plutotech.com (8.8.2/8.8.2) with ESMTP id OAA04654; Tue, 12 Nov 1996 14:20:04 -0700 (MST)
Message-Id: <199611122120.OAA04654@pluto.plutotech.com>
From: "Mike Durian" <durian@plutotech.com>
To: se@zpr.uni-koeln.de (Stefan Esser)
cc: freebsd-hackers@freebsd.org
Subject: Re: small bugs in pci code 
In-reply-to: Your message of "Tue, 12 Nov 1996 21:52:32 +0100."
Date: Tue, 12 Nov 1996 14:20:03 -0700
Sender: owner-hackers@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

On Tue, 12 Nov 1996 21:52:32 +0100, se@zpr.uni-koeln.de (Stefan Esser) wrote:
>
>Well, I'm sure it never was set to anything but 0x28 as the 
>address of the first register beyond the map registers.
>(I even checked the CVS file ...)

  I've tracked it down.  We did change it because it limited the
registers that could be mapped with pci_map_mem.  We need to be
able to read and write (reprogram) our adaptecs' seeproms.  To
do this, we map in the eeprom memory and thus need to work around
the pci_map_mem restriction.  We never realized (or even noticed until
now) the ramifications of changing the PCI_MAP_REG_END value.  Thanks
for showing us the error of our ways.

>But it was a false alarm anyway: The code will restore the old
>value of each map register at the end of the probe, and it will
>disbale the ROM at that point again.

  And it looks like we go and re-enable it later.  Sigh.  I need to
talk to some people about this.

mike