From owner-cvs-libexec  Fri Sep  9 11:35:15 1994
Return-Path: cvs-libexec-owner
Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id LAA18677 for cvs-libexec-outgoing; Fri, 9 Sep 1994 11:35:15 -0700
Received: from isl-gate.elsy.cf.ac.uk (isl-gate.elsy.cf.ac.uk [131.251.22.1]) by freefall.cdrom.com (8.6.8/8.6.6) with ESMTP id LAA18619; Fri, 9 Sep 1994 11:34:17 -0700
Received: by isl-gate.elsy.cf.ac.uk (8.6.9/1.34)
	id SAA06000; Fri, 9 Sep 1994 18:55:52 +0100
From: paul@isl.cf.ac.uk (Paul Richards)
Message-Id: <199409091755.SAA06000@isl-gate.elsy.cf.ac.uk>
Subject: Re: cvs commit: src/libexec Makefile
To: rgrimes@gndrsh.aac.dev.com (Rodney W. Grimes)
Date: Fri, 9 Sep 1994 18:55:51 +0100 (BST)
Cc: paul@freefall.cdrom.com, ache@freefall.cdrom.com, adam@freefall.cdrom.com,
        alm@freefall.cdrom.com, ats@freefall.cdrom.com, bde@freefall.cdrom.com,
        csgr@freefall.cdrom.com, cvs-libexec@freefall.cdrom.com,
        davidg@freefall.cdrom.com, dfr@freefall.cdrom.com,
        dyson@freefall.cdrom.com, gclarkii@freefall.cdrom.com,
        gpalmer@freefall.cdrom.com, guido@freefall.cdrom.com,
        hsu@freefall.cdrom.com, jkh@freefall.cdrom.com,
        joerg@freefall.cdrom.com, julian@freefall.cdrom.com,
        jvh@freefall.cdrom.com, karl@freefall.cdrom.com,
        martin@freefall.cdrom.com, nate@freefall.cdrom.com,
        phk@freefall.cdrom.com, proven@freefall.cdrom.com,
        pst@freefall.cdrom.com, rgrimes@freefall.cdrom.com,
        rich@freefall.cdrom.com, se@freefall.cdrom.com,
        sean@freefall.cdrom.com, sef@freefall.cdrom.com,
        smace@freefall.cdrom.com, sos@freefall.cdrom.com,
        torstenb@freefall.cdrom.com, wollman@freefall.cdrom.com
In-Reply-To: <199409091657.JAA11625@gndrsh.aac.dev.com> from "Rodney W. Grimes" at Sep 9, 94 09:57:34 am
X-Mailer: ELM [version 2.4 PL23]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Length: 1745      
Sender: cvs-libexec-owner@freefall.cdrom.com
Precedence: bulk

In reply to Rodney W. Grimes who said
> 
> I am not picking on paul here, even I was guilty of it this last night
> in my rush to get some things done... but we need to clean this act up,
> the log files are getting cluttered to death, and no one is getting
> reviews :-(.

I think you picked a particularly bad example since I comply with ALL the
requirements here.

> > paul        94/09/09 09:40:29
> ^^^^^^
> > 
> >   Modified:    libexec  Makefile
> >   Log:
> >   Removed bugfiler.
> >   Submitted by:	Paul Richards
>                         ^^^^^^^^^^^^

> 
> 
> Reviewed by:	
> Submitted by:	
> CVS: ----------------------------------------------------------------------
> CVS: Delete the ``Reviewed by'' line if this is somebody else's work
> CVS: (you are the reviewer).
> CVS: Delete the ``Submitted by'' line if this is NOT somebody else's
>                  ^^^^^^^^^^^^^^
> CVS: work (you are the author).

The above comments just don't make sense. The reviewed by line should
be deleted if this is NOT somebody else's work. If it IS somebody else's
work then you are the reviewer. The submitted line should never be deleted.
It should always be the originator of the code whether yourself or someone
who sent it to you for review.

> If the changes are insubstantial and noncontroversial (e.g., fixing
> spelling errors, or most Makefile changes) there is no need for
> review.  Please delete the ``Reviewed by:'' line, though, so that the
> logs look cleaner.

This is the relevant paragraph for the above commit, what did I do wrong?

-- 
  Paul Richards, FreeBSD core team member.
  Intelligent Systems Laboratory, ELSYM ,University of Wales, College Cardiff
  Internet: paul@isl.cf.ac.uk,  JANET(UK): RICHARDSDP@CARDIFF.AC.UK