From owner-freebsd-mips@FreeBSD.ORG Thu Jul 29 19:18:52 2010 Return-Path: Delivered-To: freebsd-mips@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C72E91065674; Thu, 29 Jul 2010 19:18:52 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 86CE38FC0C; Thu, 29 Jul 2010 19:18:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o6TJBPCV012997; Thu, 29 Jul 2010 13:11:25 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Thu, 29 Jul 2010 13:11:34 -0600 (MDT) Message-Id: <20100729.131134.4959786895411328.imp@bsdimp.com> To: jmallett@FreeBSD.org From: "M. Warner Losh" In-Reply-To: References: X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: freebsd-mips@FreeBSD.org Subject: Re: Support for 64bit userspace. X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jul 2010 19:18:52 -0000 In message: Juli Mallett writes: : On Thu, Jul 29, 2010 at 01:15, Jayachandran C. wrote: : > I kept the 32 bit pmap.c code untouched so that I don't have to deal with : > the breakage there during the early 64bit changes. : > I will check in the other changes now, and will do another round of work on : > pmap.c/pmap64.c to see if it can be merged (and eliminate the config : > option). : : Hmm, hopefully the changes will be well-isolated and any abstractions : will be right for 32-bit and 64-bit both. One of the problems with : two files is that when they are merged, which it sounds like you think : is inevitable, we lose the change history for that file. And if : they're in the same file, you don't need an option, just __mips_n64. I'd prefer one file as well... Warner